mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 21:34:54 +03:00
conf: nwfilter: Refactor virNWFilterFormatParamAttributes
Use virXMLFormatElement and simplify the formatter. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
3a5f9a4041
commit
bc2c392bd1
@ -731,45 +731,34 @@ virNWFilterFormatParamAttributes(virBuffer *buf,
|
||||
GHashTable *table,
|
||||
const char *filterref)
|
||||
{
|
||||
virHashKeyValuePair *items;
|
||||
size_t i, j;
|
||||
int card, numKeys;
|
||||
g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER;
|
||||
g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf);
|
||||
g_autofree virHashKeyValuePair *items = NULL;
|
||||
size_t i;
|
||||
size_t nitems;
|
||||
|
||||
numKeys = virHashSize(table);
|
||||
|
||||
if (numKeys < 0) {
|
||||
if (!(items = virHashGetItems(table, &nitems, true))) {
|
||||
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
||||
_("missing filter parameter table"));
|
||||
return -1;
|
||||
}
|
||||
|
||||
items = virHashGetItems(table, NULL, true);
|
||||
if (!items)
|
||||
return -1;
|
||||
virBufferAsprintf(&attrBuf, " filter='%s'", filterref);
|
||||
|
||||
virBufferAsprintf(buf, "<filterref filter='%s'", filterref);
|
||||
if (numKeys) {
|
||||
virBufferAddLit(buf, ">\n");
|
||||
virBufferAdjustIndent(buf, 2);
|
||||
for (i = 0; i < numKeys; i++) {
|
||||
for (i = 0; i < nitems; i++) {
|
||||
const virNWFilterVarValue *value = items[i].value;
|
||||
size_t npar = virNWFilterVarValueGetCardinality(value);
|
||||
size_t j;
|
||||
|
||||
card = virNWFilterVarValueGetCardinality(value);
|
||||
|
||||
for (j = 0; j < card; j++)
|
||||
virBufferAsprintf(buf,
|
||||
for (j = 0; j < npar; j++)
|
||||
virBufferAsprintf(&childBuf,
|
||||
"<parameter name='%s' value='%s'/>\n",
|
||||
(const char *)items[i].key,
|
||||
virNWFilterVarValueGetNthValue(value, j));
|
||||
|
||||
}
|
||||
virBufferAdjustIndent(buf, -2);
|
||||
virBufferAddLit(buf, "</filterref>\n");
|
||||
} else {
|
||||
virBufferAddLit(buf, "/>\n");
|
||||
}
|
||||
|
||||
VIR_FREE(items);
|
||||
virXMLFormatElement(buf, "filterref", &attrBuf, &childBuf);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user