diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c index e8d1b4d50d..cff2a7ed1c 100644 --- a/daemon/libvirtd-config.c +++ b/daemon/libvirtd-config.c @@ -268,8 +268,6 @@ daemonConfigNew(bool privileged ATTRIBUTE_UNUSED) data->max_requests = 20; data->max_client_requests = 5; - data->log_buffer_size = 64; - data->audit_level = 1; data->audit_logging = 0; @@ -433,7 +431,6 @@ daemonConfigLoadOptions(struct daemonConfig *data, GET_CONF_INT(conf, filename, log_level); GET_CONF_STR(conf, filename, log_filters); GET_CONF_STR(conf, filename, log_outputs); - GET_CONF_INT(conf, filename, log_buffer_size); GET_CONF_INT(conf, filename, keepalive_interval); GET_CONF_INT(conf, filename, keepalive_count); diff --git a/daemon/libvirtd-config.h b/daemon/libvirtd-config.h index 8d3d085ae2..c9969955b8 100644 --- a/daemon/libvirtd-config.h +++ b/daemon/libvirtd-config.h @@ -74,7 +74,6 @@ struct daemonConfig { int log_level; char *log_filters; char *log_outputs; - int log_buffer_size; int audit_level; int audit_logging; diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 4ee4316fb4..4179147e50 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -662,8 +662,6 @@ daemonSetupLogging(struct daemonConfig *config, virLogSetFromEnv(); - virLogSetBufferSize(config->log_buffer_size); - if (virLogGetNbFilters() == 0) virLogParseFilters(config->log_filters); diff --git a/daemon/libvirtd.conf b/daemon/libvirtd.conf index 64c215d6c3..aeba11d77c 100644 --- a/daemon/libvirtd.conf +++ b/daemon/libvirtd.conf @@ -349,11 +349,11 @@ #log_outputs="3:syslog:libvirtd" # -# Log debug buffer size: default 64 -# The daemon keeps an internal debug log buffer which will be dumped in case -# of crash or upon receiving a SIGUSR2 signal. This setting allows to override -# the default buffer size in kilobytes. -# If value is 0 or less the debug log buffer is deactivated +# Log debug buffer size: +# +# This configuration option is no longer used, since the global +# log buffer functionality has been removed. Please configure +# suitable log_outputs/log_filters settings to obtain logs. #log_buffer_size = 64 diff --git a/docs/logging.html.in b/docs/logging.html.in index a8cb53846e..d8d8f1e899 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -38,12 +38,6 @@ all messages to a debugging file but only allow errors to be logged through syslog. -
Note that the logging module saves all logs to a debug buffer - filled in a round-robin fashion as to keep a full log of the - recent logs including all debug. The debug buffer can be resized - or deactivated in the daemon using the log_buffer_size variable, - default is 64 kB. This can be used when debugging the library - (see the virLogBuffer variable content).
in libvirtd.conf and restart the daemon will allow to gather a copious amount of debugging traces for the operations done in those areas.
-On the other hand to deactivate the logbuffer in the daemon - for stable high load servers, set
-log_buffer_size=0-
in the libvirtd.conf.