shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

domain_conf: graphics: extract RDP formatting to separate function

Browse Source 
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Pavel Hrdina 2025-03-06 11:51:04 +01:00
parent 7a05d981eb
commit c2dcb47413
1 changed files with 25 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/conf/domain_conf.c
View File

@ -26507,6 +26507,30 @@ virDomainGraphicsDefFormatSDL(virBuffer *attrBuf,
virDomainGraphicsDefFormatGL(childBuf, def->data.sdl.gl, NULL);
}
static void
virDomainGraphicsDefFormatRDP(virBuffer *attrBuf,
virDomainGraphicsDef *def,
unsigned int flags)
{
virDomainGraphicsListenDef *glisten = virDomainGraphicsGetListen(def, 0);
if (def->data.rdp.port)
virBufferAsprintf(attrBuf, " port='%d'", def->data.rdp.port);
else if (def->data.rdp.autoport)
virBufferAddLit(attrBuf, " port='0'");
if (def->data.rdp.autoport)
virBufferAddLit(attrBuf, " autoport='yes'");
if (def->data.rdp.replaceUser)
virBufferAddLit(attrBuf, " replaceUser='yes'");
if (def->data.rdp.multiUser)
virBufferAddLit(attrBuf, " multiUser='yes'");
virDomainGraphicsListenDefFormatAddr(attrBuf, glisten, flags);
}
static int
virDomainGraphicsDefFormat(virBuffer *buf,
virDomainGraphicsDef *def,
@ -26537,23 +26561,7 @@ virDomainGraphicsDefFormat(virBuffer *buf,
break;
case VIR_DOMAIN_GRAPHICS_TYPE_RDP:
if (def->data.rdp.port)
virBufferAsprintf(&attrBuf, " port='%d'",
def->data.rdp.port);
else if (def->data.rdp.autoport)
virBufferAddLit(&attrBuf, " port='0'");
if (def->data.rdp.autoport)
virBufferAddLit(&attrBuf, " autoport='yes'");
if (def->data.rdp.replaceUser)
virBufferAddLit(&attrBuf, " replaceUser='yes'");
if (def->data.rdp.multiUser)
virBufferAddLit(&attrBuf, " multiUser='yes'");
virDomainGraphicsListenDefFormatAddr(&attrBuf, glisten, flags);
virDomainGraphicsDefFormatRDP(&attrBuf, def, flags);
break;
case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP: