From c951cdbff94ff577c5caa3dfff4153a161c073e6 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Mon, 10 Oct 2016 06:24:06 -0400 Subject: [PATCH] conf: Remove incorrect check when encoding shmem audit message Remove the !size check since size is initialized to NULL and thus causing the condition to always be true --- src/conf/domain_audit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index fd20ace14c..2423f34b6b 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -983,7 +983,7 @@ virDomainAuditShmem(virDomainObjPtr vm, virUUIDFormat(vm->def->uuid, uuidstr); - if (!vmname || !src || !size || !shmem || + if (!vmname || !src || !shmem || virAsprintfQuiet(&size, "%llu", def->size) < 0) { VIR_WARN("OOM while encoding audit message"); goto cleanup; @@ -997,7 +997,7 @@ virDomainAuditShmem(virDomainObjPtr vm, VIR_AUDIT(VIR_AUDIT_RECORD_RESOURCE, success, "virt=%s resrc=shmem reason=%s %s uuid=%s size=%s %s %s", - virt, reason, vmname, uuidstr, size ?: "?", shmem, src); + virt, reason, vmname, uuidstr, size, shmem, src); cleanup: VIR_FREE(vmname);