From ccafaacd61fc4ac99dac9c49cf470c3836487506 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Wed, 5 Sep 2018 11:37:00 +0200 Subject: [PATCH] qemu_security: Require full wrappers for APIs that might touch a file In the future, the transactions are not going to be optional and they will be run regardless of domain using namespace to collect list of paths to be relabeled. To make sure there won't be an API that goes behind transaction code back update the comment that serves as decision manual whether an API must be fully implemented or plain #define is sufficient. Signed-off-by: Michal Privoznik Reviewed-by: John Ferlan --- src/qemu/qemu_security.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_security.h b/src/qemu/qemu_security.h index c57774deba..ba12eb3caf 100644 --- a/src/qemu/qemu_security.h +++ b/src/qemu/qemu_security.h @@ -109,7 +109,7 @@ int qemuSecurityRestoreSavedStateLabel(virQEMUDriverPtr driver, const char *savefile); /* Please note that for these APIs there is no wrapper yet. Do NOT blindly add - * new APIs here. If an API can touch a /dev file add a proper wrapper instead. + * new APIs here. If an API can touch a file add a proper wrapper instead. */ # define qemuSecurityCheckAllLabel virSecurityManagerCheckAllLabel # define qemuSecurityClearSocketLabel virSecurityManagerClearSocketLabel