shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00
Code Releases Activity

virsh: Adjust logic checks in virshUpdateDiskXML

Browse Source 
Make it clearer that what we're trying to do is find @source and
@target_node so that the unattentive or code analysis utility
doesn't believe 'source' and 'target' could be found in the same
node element.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
John Ferlan 2019-12-17 10:43:24 -05:00
parent 93b8c6b119
commit ce7af78e39
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/virsh-domain.c
View File

@ -12476,10 +12476,9 @@ virshUpdateDiskXML(xmlNodePtr disk_node,
if (tmp->type != XML_ELEMENT_NODE)
continue;
if (virXMLNodeNameEqual(tmp, "source"))
if (!source && virXMLNodeNameEqual(tmp, "source"))
source = tmp;
if (virXMLNodeNameEqual(tmp, "target"))
else if (!target_node && virXMLNodeNameEqual(tmp, "target"))
target_node = tmp;
/*