1
0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00

qemu: Check all watchdogs for iTCO duplicates

The loop initially skipped the first one because it was mainly checking
the incompatible actions, but was then modified to also check the
duplicity of iTCO watchdogs.

While at it change the type of the iteration variable to the usual size_t.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2187133
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Martin Kletzander 2023-04-19 14:19:16 +02:00
parent 2669b442f9
commit d56ddd0d19

View File

@ -1111,9 +1111,9 @@ static int
qemuValidateDomainDefWatchdogs(const virDomainDef *def)
{
bool found_itco = false;
ssize_t i = 0;
size_t i = 0;
for (i = 1; i < def->nwatchdogs; i++) {
for (i = 0; i < def->nwatchdogs; i++) {
/* We could theoretically support different watchdogs having dump and
* pause, but let's be honest, we support multiple watchdogs only
* because we need to be able to add a second, implicit one, not because