shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 05:17:54 +03:00
Code Releases Activity

util: add file exists check in virReadFCHost

Browse Source 
File open errors are prevented by a file exists check before
virFileReadAll is called since all callers of the virReadFCHost
method handle errors themselves based on the NULL return anyway.
Also included is a minor spelling correction in a comment.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
This commit is contained in:
Boris Fiuczynski 2017-01-16 14:27:33 +01:00 committed by John Ferlan
parent 0d157b3fed
commit d59226926e
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/util/virutil.c
View File

@ -2011,7 +2011,7 @@ virGetSCSIHostNameByParentaddr(unsigned int domain,
*
* Read the value of sysfs "fc_host" entry.
*
* Returns result as a stringon success, caller must free @result after
* Returns result as a string on success, caller must free @result after
* Otherwise returns NULL.
*/
char *
@ -2029,6 +2029,9 @@ virReadFCHost(const char *sysfs_prefix,
host, entry) < 0)
goto cleanup;
if (!virFileExists(sysfs_path))
goto cleanup;
if (virFileReadAll(sysfs_path, 1024, &buf) < 0)
goto cleanup;