shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-16 03:24:31 +03:00
Code Releases Activity

qemu: Enable SCHED_CORE for vCPUs

Browse Source 
For QEMU_SCHED_CORE_VCPUS case, the vCPU threads should be placed
all into one scheduling group, but not the emulator or any of its
threads. Therefore, as soon as vCPU TIDs are detected, fork off a
child which then creates a separate scheduling group and adds all
vCPU threads into it.

Please note, this commit only handles the cold boot case. Hotplug
is going to be implemented in the next commit.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Michal Privoznik 2022-08-11 15:25:24 +02:00
parent 000477115e
commit d942422482
1 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/qemu/qemu_process.c
View File

@ -5854,9 +5854,44 @@ qemuProcessSetupVcpu(virDomainObj *vm,
}
static int
qemuProcessSetupAllVcpusSchedCoreHelper(pid_t ppid G_GNUC_UNUSED,
void *opaque)
{
virDomainObj *vm = opaque;
size_t i;
/* Since we are setting all vCPU threads at once and from a forked off
* child, we don't need the dummy schedCoreChildPID and can create one on
* our own. */
if (virProcessSchedCoreCreate() < 0) {
virReportSystemError(errno, "%s",
_("Unable to set SCHED_CORE"));
return -1;
}
for (i = 0; i < virDomainDefGetVcpusMax(vm->def); i++) {
pid_t vcpupid = qemuDomainGetVcpuPid(vm, i);
if (vcpupid > 0 &&
virProcessSchedCoreShareTo(vcpupid) < 0) {
virReportSystemError(errno,
_("unable to share scheduling cookie to %lld"),
(long long) vcpupid);
return -1;
}
}
return 0;
}
static int
qemuProcessSetupVcpus(virDomainObj *vm)
{
qemuDomainObjPrivate *priv = vm->privateData;
g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(priv->driver);
virDomainVcpuDef *vcpu;
unsigned int maxvcpus = virDomainDefGetVcpusMax(vm->def);
size_t i;
@ -5899,6 +5934,10 @@ qemuProcessSetupVcpus(virDomainObj *vm)
return -1;
}
if (cfg->schedCore == QEMU_SCHED_CORE_VCPUS &&
virProcessRunInFork(qemuProcessSetupAllVcpusSchedCoreHelper, vm) < 0)
return -1;
return 0;
}