shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-25 01:34:11 +03:00
Code Releases Activity

storage: Update qemu-img flag checking

Browse Source 
For newer qemu-img, the help string for "backing file format" is
"[-F backing_fmt]".

Fix the wrong logic error by commit e997c268.

* src/storage/storage_backend.c
This commit is contained in:
Osier Yang 2011-03-10 15:02:28 +08:00
parent e997c268ef
commit d999376954
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/storage/storage_backend.c
View File

@ -595,7 +595,8 @@ static int virStorageBackendQEMUImgBackingFormat(const char *qemuimg)
start = strstr(help, " create ");
end = strstr(start, "\n");
if ((tmp = strstr(start, "-F fmt")) && tmp < end)
if (((tmp = strstr(start, "-F fmt")) && tmp < end) ||
((tmp = strstr(start, "-F backing_fmt")) && tmp < end))
ret = QEMU_IMG_BACKING_FORMAT_FLAG;
else if ((tmp = strstr(start, "[-o options]")) && tmp < end)
ret = QEMU_IMG_BACKING_FORMAT_OPTIONS;
@ -757,7 +758,7 @@ virStorageBackendCreateQemuImg(virConnectPtr conn,
};
if (vol->target.encryption != NULL) {
if (imgformat == QEMU_IMG_BACKING_FORMAT_FLAG) {
if (imgformat == QEMU_IMG_BACKING_FORMAT_OPTIONS) {
imgargv[8] = "-o";
imgargv[9] = "encryption=on";
} else {
@ -837,7 +838,7 @@ virStorageBackendCreateQemuImg(virConnectPtr conn,
};
if (vol->target.encryption != NULL) {
if (imgformat == QEMU_IMG_BACKING_FORMAT_FLAG) {
if (imgformat == QEMU_IMG_BACKING_FORMAT_OPTIONS) {
imgargv[6] = "-o";
imgargv[7] = "encryption=on";
} else {