From e36b1f6583324133405c7f4552a9da51e6c61161 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Fri, 1 Jun 2018 10:32:49 +0200 Subject: [PATCH] qemu: Fix reporting completed migration stats on destination This has been broken since commit v4.0.0-165-g93412bb827 which added jobInfo->statsType enum to distinguish various statistics types. During migration the type will always be QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION, however the destination code consuming the statistics data from migration cookie failed to properly set the type. So even though everything was filled in, the type remained *_NONE and any attempt to fetch the statistics data of a completed migration on the destination host failed. https://bugzilla.redhat.com/show_bug.cgi?id=1584071 Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 68663eac47..70616b568e 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5160,6 +5160,7 @@ qemuMigrationDstFinish(virQEMUDriverPtr driver, if (jobInfo) { VIR_STEAL_PTR(priv->job.completed, jobInfo); priv->job.completed->status = QEMU_DOMAIN_JOB_STATUS_COMPLETED; + priv->job.completed->statsType = QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION; } if (qemuMigrationBakeCookie(mig, driver, vm,