shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00
Code Releases Activity

network: fix (non)update of dnsmasq config during virDomainUpdateDeviceFlags

Browse Source 
A forgotten "!" in recently-modified code at the top of
networkRefreshDaemon() meant an improper early return, which led to 1)
dnsmasq config files not being updated from the newly modified config,
and 2) dnsmasq not being sent a SIGHUP so that it could learn about
the changes to the config.

virNetworkDefGetIpByIndex() returns NULL if there are no ip objects of
the requested type, and if there are no IP elements, then dnsmasq
shouldn't be running, so we can return early. Otherwise we should
rewrite the config files and send a SIGHUP.
This commit is contained in:
Laine Stump 2012-12-14 12:44:03 -05:00
parent 238dba0f9c
commit e3802e13df
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/bridge_driver.c
View File

@ -1123,7 +1123,7 @@ networkRefreshDhcpDaemon(struct network_driver *driver,
dnsmasqContext *dctx = NULL;
/* if no IP addresses specified, nothing to do */
if (virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, 0))
if (!virNetworkDefGetIpByIndex(network->def, AF_UNSPEC, 0))
return 0;
/* if there's no running dnsmasq, just start it */