shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00
Code Releases Activity

lxcxml2xmltest: Substitute 'inactive' variable with 'active'

Browse Source 
I removed negation from the name of a variable to make the code
more readable.

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Kristina Hanicova 2021-07-21 10:25:22 +02:00 committed by Michal Privoznik
parent fb234839a7
commit e70e8e2dd8
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/lxcxml2xmltest.c
View File

@ -21,7 +21,7 @@ static virLXCDriver *driver;
struct testInfo { struct testInfo {
const char *name; const char *name;
int different; int different;
bool inactive_only; bool active_only;
unsigned int parse_flags; unsigned int parse_flags;
}; };
@ -40,7 +40,7 @@ testCompareXMLToXMLHelper(const void *data)
ret = testCompareDomXML2XMLFiles(driver->caps, driver->xmlopt, xml_in, ret = testCompareDomXML2XMLFiles(driver->caps, driver->xmlopt, xml_in,
info->different ? xml_out : xml_in, info->different ? xml_out : xml_in,
!info->inactive_only, info->active_only,
info->parse_flags, info->parse_flags,
TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS); TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS);
VIR_FREE(xml_in); VIR_FREE(xml_in);
@ -57,9 +57,9 @@ mymain(void)
if (!(driver = testLXCDriverInit())) if (!(driver = testLXCDriverInit()))
return EXIT_FAILURE; return EXIT_FAILURE;
# define DO_TEST_FULL(name, is_different, inactive, parse_flags) \ # define DO_TEST_FULL(name, is_different, active, parse_flags) \
do { \ do { \
const struct testInfo info = {name, is_different, inactive, \ const struct testInfo info = {name, is_different, active, \
parse_flags}; \ parse_flags}; \
if (virTestRun("LXC XML-2-XML " name, \ if (virTestRun("LXC XML-2-XML " name, \
testCompareXMLToXMLHelper, &info) < 0) \ testCompareXMLToXMLHelper, &info) < 0) \
@ -67,10 +67,10 @@ mymain(void)
} while (0) } while (0)
# define DO_TEST(name) \ # define DO_TEST(name) \
DO_TEST_FULL(name, 0, false, 0) DO_TEST_FULL(name, 0, true, 0)
# define DO_TEST_DIFFERENT(name) \ # define DO_TEST_DIFFERENT(name) \
DO_TEST_FULL(name, 1, false, 0) DO_TEST_FULL(name, 1, true, 0)
/* Unset or set all envvars here that are copied in lxcdBuildCommandLine /* Unset or set all envvars here that are copied in lxcdBuildCommandLine
* using ADD_ENV_COPY, otherwise these tests may fail due to unexpected * using ADD_ENV_COPY, otherwise these tests may fail due to unexpected