shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-25 01:34:11 +03:00
Code Releases Activity

virSCSIHostFindByPCI: Fix link detection

Browse Source 
Inside of virSCSIHostFindByPCI() there's a loop which iterates of
entries of "/sys/class/scsi_host" directory trying to identify
all symlinks (which then point to a SCSI device, but that's not
important right now). But the way virFileIsLink() is called can
never return a truthful reply - because it's called over
dent->d_name instead of full path. Fix this by moving the
virFileIsLink() call and passing constructed path into it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2023-03-08 08:42:19 +01:00
parent 20a719dce6
commit e8a83aab5d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/virscsihost.c
View File

@ -107,11 +107,11 @@ virSCSIHostFindByPCI(const char *sysfs_prefix,
char *p = NULL; char *p = NULL;
unsigned int read_unique_id; unsigned int read_unique_id;
if (!virFileIsLink(entry->d_name))
continue;
host_link = g_strdup_printf("%s/%s", prefix, entry->d_name); host_link = g_strdup_printf("%s/%s", prefix, entry->d_name);
if (!virFileIsLink(host_link))
continue;
if (virFileResolveLink(host_link, &host_path) < 0) if (virFileResolveLink(host_link, &host_path) < 0)
return NULL; return NULL;