mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-25 01:34:11 +03:00
virsh: check the return value of virStoragePoolGetAutostart
On error, virStoragePoolGetAutostart would return -1 leaving autostart untouched. Removed the misleading debug message as well. Error: CHECKED_RETURN (CWE-252): libvirt-0.10.2/tools/virsh-pool.c:1386: unchecked_value: No check of the return value of "virStoragePoolGetAutostart(pool, &autostart)".
This commit is contained in:
parent
6c5c4b8d4d
commit
e9d74a7a82
@ -1383,10 +1383,7 @@ cmdPoolInfo(vshControl *ctl, const vshCmd *cmd)
|
|||||||
vshPrint(ctl, "%-15s %s\n", _("Persistent:"), persistent ? _("yes") : _("no"));
|
vshPrint(ctl, "%-15s %s\n", _("Persistent:"), persistent ? _("yes") : _("no"));
|
||||||
|
|
||||||
/* Check and display whether the pool is autostarted or not */
|
/* Check and display whether the pool is autostarted or not */
|
||||||
virStoragePoolGetAutostart(pool, &autostart);
|
if (virStoragePoolGetAutostart(pool, &autostart) < 0)
|
||||||
vshDebug(ctl, VSH_ERR_DEBUG, "Pool autostart flag value: %d\n",
|
|
||||||
autostart);
|
|
||||||
if (autostart < 0)
|
|
||||||
vshPrint(ctl, "%-15s %s\n", _("Autostart:"), _("no autostart"));
|
vshPrint(ctl, "%-15s %s\n", _("Autostart:"), _("no autostart"));
|
||||||
else
|
else
|
||||||
vshPrint(ctl, "%-15s %s\n", _("Autostart:"), autostart ? _("yes") : _("no"));
|
vshPrint(ctl, "%-15s %s\n", _("Autostart:"), autostart ? _("yes") : _("no"));
|
||||||
|
Loading…
Reference in New Issue
Block a user