shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

qemu: domain: Remove qemuDomainSupportsCheckpointsBlockjobs

Browse Source 
The function now serves no real purpose.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2025-03-12 17:08:33 +01:00
parent e1bce4ecd2
commit eb27abb415
5 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/qemu/qemu_block.c
View File

@ -3592,9 +3592,6 @@ qemuBlockCommit(virDomainObj *vm,
if (qemuDomainDiskBlockJobIsActive(disk))
return NULL;
if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0)
return NULL;
if (topSource == disk->src) {
/* XXX Should we auto-pivot when COMMIT_ACTIVE is not specified? */
if (!(flags & VIR_DOMAIN_BLOCK_COMMIT_ACTIVE)) {

14
src/qemu/qemu_domain.c
View File

@ -10169,20 +10169,6 @@ qemuDomainDefHasManagedPR(virDomainObj *vm)
}
/**
* qemuDomainSupportsCheckpointsBlockjobs:
* @vm: domain object
*
* Checks whether a block job is supported in possible combination with
* checkpoints (qcow2 bitmaps). Returns -1 if unsupported and reports an error
* 0 in case everything is supported.
*/
int
qemuDomainSupportsCheckpointsBlockjobs(virDomainObj *vm G_GNUC_UNUSED)
{
return 0;
}
/**
* qemuDomainInitializePflashStorageSource:
*

4
src/qemu/qemu_domain.h
View File

@ -1053,10 +1053,6 @@ int
qemuDomainValidateActualNetDef(const virDomainNetDef *net,
virQEMUCaps *qemuCaps);
int
qemuDomainSupportsCheckpointsBlockjobs(virDomainObj *vm)
G_GNUC_WARN_UNUSED_RESULT;
int
qemuDomainMakeCPUMigratable(virArch arch,
virCPUDef *cpu,

6
src/qemu/qemu_driver.c
View File

@ -13624,9 +13624,6 @@ qemuDomainBlockPullCommon(virDomainObj *vm,
if (virDomainObjCheckActive(vm) < 0)
goto endjob;
if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0)
goto endjob;
if (!(disk = qemuDomainDiskByName(vm->def, path)))
goto endjob;
@ -14150,9 +14147,6 @@ qemuDomainBlockCopyCommon(virDomainObj *vm,
if (virDomainObjCheckActive(vm) < 0)
goto endjob;
if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0)
goto endjob;
if (!(disk = qemuDomainDiskByName(vm->def, path)))
goto endjob;

4
src/qemu/qemu_snapshot.c
View File

@ -1082,7 +1082,6 @@ qemuSnapshotPrepare(virDomainObj *vm,
}
/* Handle interlocking with 'checkpoints':
* - if the VM is online use qemuDomainSupportsCheckpointsBlockjobs
* - if the VM is offline disallow external snapshots as the support for
* propagating bitmaps into the would-be-created overlay is not yet implemented
*/
@ -1093,9 +1092,6 @@ qemuSnapshotPrepare(virDomainObj *vm,
_("support for offline external snapshots while checkpoint exists was not yet implemented"));
return -1;
}
} else {
if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0)
return -1;
}
/* Alter flags to let later users know what we learned. */