diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 127abfe69a..f51e766108 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10711,7 +10711,7 @@ qemuNodeDeviceDetachFlags(virNodeDevicePtr dev, virObjectLock(driver->inactivePciHostdevs); if (virPCIDeviceDetach(pci, driver->activePciHostdevs, - driver->inactivePciHostdevs, NULL) < 0) { + driver->inactivePciHostdevs) < 0) { goto out; } diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index c507c31110..d7d54d7241 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -540,7 +540,7 @@ int qemuPrepareHostdevPCIDevices(virQEMUDriverPtr driver, for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) { virPCIDevicePtr dev = virPCIDeviceListGet(pcidevs, i); if (virPCIDeviceGetManaged(dev) && - virPCIDeviceDetach(dev, driver->activePciHostdevs, NULL, NULL) < 0) + virPCIDeviceDetach(dev, driver->activePciHostdevs, NULL) < 0) goto reattachdevs; } diff --git a/src/util/virpci.c b/src/util/virpci.c index 2f4032f516..2980e22d3e 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -1238,15 +1238,12 @@ cleanup: int virPCIDeviceDetach(virPCIDevicePtr dev, virPCIDeviceList *activeDevs, - virPCIDeviceList *inactiveDevs, - const char *driver) + virPCIDeviceList *inactiveDevs) { - if (!driver && dev->stubDriver) - driver = dev->stubDriver; - - if (virPCIProbeStubDriver(driver) < 0) { + if (virPCIProbeStubDriver(dev->stubDriver) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to load PCI stub module %s"), driver); + _("Failed to load PCI stub module %s"), + dev->stubDriver); return -1; } @@ -1256,7 +1253,7 @@ virPCIDeviceDetach(virPCIDevicePtr dev, return -1; } - if (virPCIDeviceBindToStub(dev, driver) < 0) + if (virPCIDeviceBindToStub(dev, dev->stubDriver) < 0) return -1; /* Add *a copy of* the dev into list inactiveDevs, if diff --git a/src/util/virpci.h b/src/util/virpci.h index d069adba0d..944aa09db4 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -51,8 +51,7 @@ const char *virPCIDeviceGetName(virPCIDevicePtr dev); int virPCIDeviceDetach(virPCIDevicePtr dev, virPCIDeviceListPtr activeDevs, - virPCIDeviceListPtr inactiveDevs, - const char *driver); + virPCIDeviceListPtr inactiveDevs); int virPCIDeviceReattach(virPCIDevicePtr dev, virPCIDeviceListPtr activeDevs, virPCIDeviceListPtr inactiveDevs); diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index 38adb23bb2..f69feb581f 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -2440,7 +2440,7 @@ xenUnifiedNodeDeviceDetachFlags(virNodeDevicePtr dev, goto out; } - if (virPCIDeviceDetach(pci, NULL, NULL, NULL) < 0) + if (virPCIDeviceDetach(pci, NULL, NULL) < 0) goto out; ret = 0;