shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-12 13:17:58 +03:00
Code Releases Activity

virSecurityManagerMetadataLock: Expand the comment on deadlocks

Browse Source 
Document why we need to sort paths while it's still fresh in my
memory.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
Michal Privoznik 2019-07-18 10:58:19 +02:00
parent 48df09874b
commit ee6501ab05
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/security/security_manager.c
View File

@ -1289,7 +1289,12 @@ virSecurityManagerMetadataLock(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
if (VIR_ALLOC_N(fds, npaths) < 0) if (VIR_ALLOC_N(fds, npaths) < 0)
return NULL; return NULL;
/* Sort paths to lock in order to avoid deadlocks. */ /* Sort paths to lock in order to avoid deadlocks with other
* processes. For instance, if one process wants to lock
* paths A B and there's another that is trying to lock them
* in reversed order a deadlock might occur. But if we sort
* the paths alphabetically then both processes will try lock
* paths in the same order and thus no deadlock can occur. */
qsort(paths, npaths, sizeof(*paths), cmpstringp); qsort(paths, npaths, sizeof(*paths), cmpstringp);
for (i = 0; i < npaths; i++) { for (i = 0; i < npaths; i++) {