shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-08-24 09:49:59 +03:00
Code Releases Activity

remove a static limit on max domains in python bindings

Browse Source 
* python/libvirt-override.c: remove the predefined array in the
  virConnectListDomainsID binding and call virConnectNumOfDomains
  to do a proper allocation
This commit is contained in:
Daniel Veillard
2011-12-29 16:20:00 +08:00
parent ae3315aa4a
commit f0293edc3f
1 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
python/libvirt-override.c
View File

@ -1616,7 +1616,7 @@ static PyObject *
libvirt_virConnectListDomainsID(PyObject *self ATTRIBUTE_UNUSED, libvirt_virConnectListDomainsID(PyObject *self ATTRIBUTE_UNUSED,
PyObject *args) { PyObject *args) {
PyObject *py_retval; PyObject *py_retval;
int ids[500], c_retval, i; int *ids = NULL, c_retval, i;
virConnectPtr conn; virConnectPtr conn;
PyObject *pyobj_conn; PyObject *pyobj_conn;
@ -1626,14 +1626,33 @@ libvirt_virConnectListDomainsID(PyObject *self ATTRIBUTE_UNUSED,
conn = (virConnectPtr) PyvirConnect_Get(pyobj_conn); conn = (virConnectPtr) PyvirConnect_Get(pyobj_conn);
LIBVIRT_BEGIN_ALLOW_THREADS; LIBVIRT_BEGIN_ALLOW_THREADS;
c_retval = virConnectListDomains(conn, &ids[0], 500); c_retval = virConnectNumOfDomains(conn);
LIBVIRT_END_ALLOW_THREADS; LIBVIRT_END_ALLOW_THREADS;
if (c_retval < 0) if (c_retval < 0)
return VIR_PY_NONE; return VIR_PY_NONE;
py_retval = PyList_New(c_retval);
for (i = 0;i < c_retval;i++) { if (c_retval) {
PyList_SetItem(py_retval, i, libvirt_intWrap(ids[i])); ids = malloc(sizeof(*ids) * c_retval);
if (!ids)
return VIR_PY_NONE;
LIBVIRT_BEGIN_ALLOW_THREADS;
c_retval = virConnectListDomains(conn, ids, c_retval);
LIBVIRT_END_ALLOW_THREADS;
if (c_retval < 0) {
free(ids);
return VIR_PY_NONE;
}
} }
py_retval = PyList_New(c_retval);
if (ids) {
for (i = 0;i < c_retval;i++) {
PyList_SetItem(py_retval, i, libvirt_intWrap(ids[i]));
}
free(ids);
}
return(py_retval); return(py_retval);
} }