shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-14 23:24:23 +03:00
Code Releases Activity

virtime: Resolve Coverity DEADCODE

Browse Source 
Coverity complains that because of how 'offset' is initialized to
0 (zero), the resulting math and comparison on rem is pointless.

According to the origin commit id '3ec128989', the code is a
replacement for gmtime(), but without the localtime() or GMT
calculations - so just remove this code and add a comment
indicating the removal
This commit is contained in:
John Ferlan 2014-09-11 17:29:18 -04:00
parent 9545d062c7
commit f26e6397b3
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/util/virtime.c
View File

@ -127,22 +127,16 @@ const unsigned short int __mon_yday[2][13] = {
void virTimeFieldsThen(unsigned long long when, struct tm *fields)
{
/* This code is taken from GLibC under terms of LGPLv2+ */
/* Remove the 'offset' or GMT manipulation since we don't care. See
* commit id '3ec12898' comments regarding localtime.
*/
long int days, rem, y;
const unsigned short int *ip;
unsigned long long whenSecs = when / 1000ull;
unsigned int offset = 0; /* We hardcoded GMT */
days = whenSecs / SECS_PER_DAY;
rem = whenSecs % SECS_PER_DAY;
rem += offset;
while (rem < 0) {
rem += SECS_PER_DAY;
--days;
}
while (rem >= SECS_PER_DAY) {
rem -= SECS_PER_DAY;
++days;
}
fields->tm_hour = rem / SECS_PER_HOUR;
rem %= SECS_PER_HOUR;
fields->tm_min = rem / 60;