mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-13 17:18:01 +03:00
qemu: Use virQEMUCapsCacheLookupDefault instead of lookup by arch
Firstly, SEV is present only on AMD, so we can safely assume x86. Secondly, the problem with looking up capabilities in the cache by arch is that it's using virHashSearch with a callback to find the right capabilities and get the binary name from it as well, but since the cache is empty, it will return NULL and we won't get the corresponding binary name out of the lookup either. Then, during the cache validation we try to create a new cache entry for the emulator, but since we don't have the binary name, nothing gets created. Therefore, virQEMUCapsCacheLookupDefault is used to fix this issue, because it doesn't rely on the capabilities cache to construct the emulator binary name. https://bugzilla.redhat.com/show_bug.cgi?id=1852311 Signed-off-by: Erik Skultety <eskultet@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
parent
049846b9fd
commit
f3d838237d
@ -22823,8 +22823,10 @@ qemuNodeGetSEVInfo(virConnectPtr conn,
|
||||
if (virNodeGetSevInfoEnsureACL(conn) < 0)
|
||||
return -1;
|
||||
|
||||
qemucaps = virQEMUCapsCacheLookupByArch(driver->qemuCapsCache,
|
||||
virArchFromHost());
|
||||
qemucaps = virQEMUCapsCacheLookupDefault(driver->qemuCapsCache,
|
||||
NULL, NULL, NULL, NULL,
|
||||
NULL, NULL, NULL);
|
||||
|
||||
if (!qemucaps)
|
||||
return -1;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user