shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

qemuDomainGetStatsCpuHaltPollTime: Remove return value

Browse Source 
The function can't fail. Remove return value and refactor callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2025-02-17 13:51:10 +01:00
parent acad77f04b
commit f660984273
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/qemu/qemu_driver.c
View File

@ -16920,7 +16920,7 @@ qemuDomainGetStatsCpuHaltPollTimeFromStats(virDomainObj *dom,
}
static int
static void
qemuDomainGetStatsCpuHaltPollTime(virDomainObj *dom,
virTypedParamList *params,
unsigned int privflags)
@ -16929,17 +16929,17 @@ qemuDomainGetStatsCpuHaltPollTime(virDomainObj *dom,
unsigned long long haltPollFail = 0;
if (!virDomainObjIsActive(dom))
return 0;
return;
if (qemuDomainGetStatsCpuHaltPollTimeFromStats(dom, privflags,
&haltPollSuccess, &haltPollFail) < 0 &&
virHostCPUGetHaltPollTime(dom->pid, &haltPollSuccess, &haltPollFail) < 0)
return 0;
return;
virTypedParamListAddULLong(params, haltPollSuccess, "cpu.haltpoll.success.time");
virTypedParamListAddULLong(params, haltPollFail, "cpu.haltpoll.fail.time");
return 0;
return;
}
static int
@ -16959,8 +16959,7 @@ qemuDomainGetStatsCpu(virQEMUDriver *driver,
if (qemuDomainGetStatsCpuCache(driver, dom, params) < 0)
return -1;
if (qemuDomainGetStatsCpuHaltPollTime(dom, params, privflags) < 0)
return -1;
qemuDomainGetStatsCpuHaltPollTime(dom, params, privflags);
return 0;
}