shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-24 22:50:26 +03:00
Code Releases Activity

virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps

Browse Source 
The noRefresh member of _dnsmasqCaps struct is set only after it
was checked for and is never checked again. This is needless and
the member can be removed. There is no way that
dnsmasqCapsRefreshInternal() can be called after
dnsmasqCapsSetFromBuffer().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
Michal Privoznik 2022-01-17 13:20:32 +01:00
parent 0a7224a147
commit f947b2343a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/util/virdnsmasq.c
View File

@ -576,7 +576,6 @@ dnsmasqReload(pid_t pid G_GNUC_UNUSED)
struct _dnsmasqCaps {
virObject parent;
char *binaryPath;
bool noRefresh;
unsigned long version;
};
@ -609,8 +608,6 @@ dnsmasqCapsSetFromBuffer(dnsmasqCaps *caps, const char *buf)
int len;
const char *p;
caps->noRefresh = true;
p = STRSKIP(buf, DNSMASQ_VERSION_STR);
if (!p)
goto error;
@ -656,7 +653,7 @@ dnsmasqCapsRefreshInternal(dnsmasqCaps *caps)
g_autofree char *version = NULL;
g_autofree char *complete = NULL;
if (!caps || caps->noRefresh)
if (!caps)
return 0;
/* Make sure the binary we are about to try exec'ing exists.