shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 21:34:54 +03:00
Code Releases Activity

storage: Prior to creating a volume, refresh the pool

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=1233003

Although perhaps bordering on a don't do that type scenario, if
someone creates a volume in a pool outside of libvirt, then uses that
same name to create a volume in the pool via libvirt, then the creation
will fail and in some cases cause the same name volume to be deleted.

This patch will refresh the pool just prior to checking whether the
named volume exists prior to creating the volume in the pool. While
it's still possible to have a timing window to create a file after the
check - at least we tried.  At that point, someone is being malicious.
This commit is contained in:
John Ferlan 2015-09-30 17:53:01 -04:00
parent cb19cff468
commit fdda37608a
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/storage/storage_driver.c
View File

@ -1796,6 +1796,15 @@ storageVolCreateXML(virStoragePoolPtr obj,
if (virStorageVolCreateXMLEnsureACL(obj->conn, pool->def, voldef) < 0)
goto cleanup;
/* While not perfect, refresh the list of volumes in the pool and
* then check that the incoming name isn't already in the pool.
*/
if (backend->refreshPool) {
virStoragePoolObjClearVols(pool);
if (backend->refreshPool(obj->conn, pool) < 0)
goto cleanup;
}
if (virStorageVolDefFindByName(pool, voldef->name)) {
virReportError(VIR_ERR_STORAGE_VOL_EXIST,
_("'%s'"), voldef->name);