3 Commits

Author	SHA1	Message	Date
Peter Krempa	b528fffc6f	vmx: Mark CDROM disk elements as read-only ... Mark it explicitly as read only in accordance with the comment outlining configuration. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>	2021-04-19 14:43:59 +02:00
Peter Krempa	d504297993	tests: vmx: Add <name> element for all domain XMLs ... <name> is mandatory for a domain XML. Add 'displayName' for all the test cases which were missing them so that <name> is parsed correctly. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Pino Toscano <ptoscano@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>	2020-10-20 09:05:10 +02:00
Pino Toscano	c5ee737bc5	vmx: make 'fileName' optional for CD-ROMs ... It seems like CD-ROMs may have no 'fileName' property specified in case there is nothing configured as attachment for the drive. Hence, make sure that virVMXParseDisk() do not consider it mandatory anymore, considering it an empty block cdrom device. Sadly virVMXParseDisk() is used also to parse disk and floppies, so make sure that a NULL fileName is handled in cdrom- and floppy-related paths. https://bugzilla.redhat.com/show_bug.cgi?id=1808610 Signed-off-by: Pino Toscano <ptoscano@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com> Tested-by: Richard W.M. Jones <rjones@redhat.com>	2020-03-19 11:25:33 +01:00