2 Commits

Author	SHA1	Message	Date
shenjiatong	7bc7304ca5	qemu: Remove scsi parameter for vhost-user-blk for qemu < 4.2 ... When trying to attach vhost-user-blk device to virtual machine using qemu < 4.2 libvirt would mistakenly add a scsi=off parameter, which is not supported by qemu. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/265 Signed-off-by: shenjiatong <yshxxsjt715@gmail.com> Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com>	2022-01-24 10:17:00 +01:00
Peter Krempa	5e645b80f4	qemuxml2argvtest: disk-vhostuser: Add invocation for qemu-4.2 ... With qemu versions prior to qemu-5.0 we'll format 'scsi=off' for virtio-blk disks, but also for vhost-user-blk. This is a bug as it's not supported. Add a test case to show that wrong configuration is generated by adding running 'disk-vhostuser' test case on capabilities from qemu-4.2. For this to be possible it's required to enable shared memory via NUMA configuration as old QEMU's don't allow configuration of the default memory backend. This is achieved by adding a copy of the 'disk-vhostuser' XML with NUMA enabled. Signed-off-by: Peter Krempa <pkrempa@redhat.com>	2022-01-24 10:17:00 +01:00