2 Commits

Author	SHA1	Message	Date
Daniel Henrique Barboza	06ebad7c78	tests: refactor pseries features parse failure tests ... The qemuxml2argvtest pseries-feature parse failure tests uses a symlink to the pseries-features.xml test domain and control which feature it is supposed to fail by excluding it from the capabilities list. The advantage of this approach is that the same XML can be used in multiple tests. One downside is that any new pseries capability must be declared in all existent tests, otherwise all other tests can break if this new capability happens to be validated early in qemu_validate.c. Any new parse_error test must declare all other existent capabilities. Another downside is the fact that we're testing fairly improbable scenarios: all pseries capabilities being tested here were introduced by the same QEMU version, 4.2.0, at least as far as libvirt is aware of. This means that it's no possible to have a scenario where, for example, ccf-assist is not present but cfpc is. And last, but not the least, it's getting in the way of our effort to convert all pseries tests to not use explicit capabilities. Changing all these tests to use DO_TEST_PARSE_ERROR_NOCAPS() will allow us to test exactly what we want to test, which is the parse error given for each feature if the binary does not have support for it. The XML being used for each test can be simplified to just declare a single feature. In the end we'll end up with more XML lines, but less complexity inside qemuxml2argvtest.c. Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>	2022-10-13 16:28:01 -03:00
Sebastian Mitterle	9ec77eef2d	qemuxml2argvtest: Test expected error messages ... When an error is expected, the error message will be checked. This is expressed by creating an additional ".err" file containing the expected error message. It is added in order to make sure the expected errors are not masked by other errors during test execution while leveraging the existing framework. In order to keep it simple, an input file cannot be reused anymore to cover several expected error cases configured in the test code. An input file can still be reused by creating a test case specific symlink. For consistency, the mock needs to report an error now, too, as every failure must have an error; otherwise a test case will fail. Require LC_ALL=C explicitly to make sure error messages are not localized for testing. Signed-off-by: Sebastian Mitterle <smitterl@redhat.com> Suggested-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com>	2020-09-23 22:47:59 +02:00