3 Commits

Author	SHA1	Message	Date
Daniel P. Berrangé	72874b2d11	tests: validate private data / pre / post exec hooks for RPC APIs ... Validate that the virNetServer(Client) RPC APIs are processing the private data callbacks correctly by passing in non-NULL pointers. Reviewed-by: John Ferlan <jferlan@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>	2018-02-02 13:00:48 +00:00
Erik Skultety	4ac0d545e8	test: Replace tabs with spaces in virnetdaemondata json files ... JSON data that are used to initialize tests in virnetdaemontest should be in a consistent format, i.e. not using tabs for indentation, those should be replaced by spaces.	2015-08-24 09:30:40 +02:00
Martin Kletzander	a8743c3938	rpc: Remove keepalive_required option ... Since its introduction in 2011 (particularly in commit f4324e3292), the option doesn't work. It just effectively disables all incoming connections. That's because the client private data that contain the 'keepalive_supported' boolean, are initialized to zeroes so the bool is false and the only other place where the bool is used is when checking whether the client supports keepalive. Thus, according to the server, no client supports keepalive. Removing this instead of fixing it is better because a) apparently nobody ever tried it since 2011 (4 years without one month) and b) we cannot know whether the client supports keepalive until we get a ping or pong keepalive packet. And that won't happen until after we dispatched the ConnectOpen call. Another two reasons would be c) the keepalive_required was tracked on the server level, but keepalive_supported was in private data of the client as well as the check that was made in the remote layer, thus making all other instances of virNetServer miss this feature unless they all implemented it for themselves and d) we can always add it back in case there is a request and a use-case for it. Signed-off-by: Martin Kletzander <mkletzan@redhat.com>	2015-08-10 13:15:56 +02:00