3 Commits

Author	SHA1	Message	Date
Jiri Denemark	48341b025a	cpu_x86: Penalize disabled features when computing CPU model ... For finding the best matching CPU model for a given set of features while we don't know the CPU signature (i.e., when computing a baseline CPU model) we've been using a "shortest list of features" heuristics. This works well if new CPU models are supersets of older models, but that's not always the case. As a result it may actually select a new CPU model as a baseline while removing some features from it to make it compatible with older models. This is in general worse than using an old CPU model with a bunch of added features as a guest OS or apps may crash when using features that were disabled. On the other hand we don't want to end up with a very old model which would guarantee no disabled features as it could stop a guest OS or apps from using some features provided by the CPU because they would not expect them on such an old CPU. This patch changes the heuristics to something in between. Enabled and disabled features are counted separately so that a CPU model requiring some features to be disabled looks worse than a model with fewer disabled features even if its complete list of features is longer. The penalty given for each additional disabled feature gets bigger to make longer list of disabled features look even worse. https://bugzilla.redhat.com/show_bug.cgi?id=1851227 Signed-off-by: Jiri Denemark <jdenemar@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>	2022-05-06 17:33:47 +02:00
Jiri Denemark	5cbc247e0d	Do not format <arch> in guest CPU XML ... This element is only allowed for host CPUs. Signed-off-by: Jiri Denemark <jdenemar@redhat.com>	2017-03-13 23:49:57 +01:00
Jiri Denemark	3944aba1df	cputest: Rename x86 data files ... While "x86" is a CPU sub driver name, it is not a recognized name of any architecture known to libvirt. Let's use "x86_64" prefix which can be used with virArch APIs. Signed-off-by: Jiri Denemark <jdenemar@redhat.com>	2017-02-24 14:10:57 +01:00