3 Commits

Author	SHA1	Message	Date
Peter Krempa	b40ec75296	qemu: Forbid non-raw images for disk type='lun' with vitio-blk frontend ... Historically the virtio-blk frontend by default enabled SCSI emulation and tried to do SCSI command passthrough. As this was enabled by default there's a fallback mechanism in place in cases when the backend doesn't support SCSI for any reason. This is not the case when disk type=lun is used with 'scsi-block' via 'virtio-scsi'. We did not restrict configurations when the user picks 'qcow2' or any other format as format of the disk, in which case the emulation is disabled as such configuration doesn't make sense. This patch unifies the approach so that 'raw' is required both when used via 'virtio-blk' and 'virtio-scsi' so that the user is presented with the expected configuration. Note that use of <disk type='lun'> is already very restrictive as it requires a block device or iSCSI storage. Additionally the scsi emulation is now deprecated by qemu with virtio-blk as it conflicts with virtio-1 and the alternative is to use 'virtio-scsi' which performs better and is along for a very long time. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>	2020-05-12 06:55:00 +02:00
Peter Krempa	de723a29a3	tests: qemuxml: Remove prehistoric machine types from legacy tests ... None of the tests depend on anything that the machine type would influence. This will allow us to drop the very old machine type from the non-real-data tests. If something depends on the machine type it should be tested with real data rather than this hack. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>	2020-01-27 14:55:03 +01:00
Michal Privoznik	4d82c8fd61	test: Drop useless prefix for qemuxml2xmldata test data ... There's no reason for the files to have qemuxml2xmlout- prefix since they all live under qemuxml2xmloutdata directory. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>	2017-12-05 14:52:49 +01:00