6 Commits

Author	SHA1	Message	Date
Eric Blake	cc5e2a849c	command: improve behavior on no output ... Guarantee that outbuf/errbuf are allocated on success, even if to the empty string. Caller always has to free the result, and empty output check requires checking if *outbuf=='\0'. Makes the API easier to use safely. Failure is best effort allocation (some paths, like out-of-memory, cannot allocate a buffer, but most do), so caller must free buffer on failure. * docs/internals/command.html.in: Update documentation. * src/util/command.c (virCommandSetOutputBuffer) (virCommandSetErrorBuffer, virCommandProcessIO) Guarantee empty string on no output. * tests/commandtest.c (test17): New test.	2010-12-07 15:35:30 -07:00
Jiri Denemark	ea8389dd3d	tests: Fix commandtest in VPATH build	2010-12-07 09:34:09 -07:00
Eric Blake	3c63a15b77	tests: fix leaks in commandtest ... Most leaks could only occur on error cleanup paths.	2010-12-07 09:34:09 -07:00
Jiri Denemark	c1c1ff7e47	tests: Fix detection of expected error	2010-12-07 17:11:25 +01:00
Jiri Denemark	49c612b39e	tests: Fix code formating in commandtest	2010-12-07 17:11:24 +01:00
Daniel P. Berrange	f16ad06fb2	Introduce new APIs for spawning processes ... This introduces a new set of APIs in src/util/command.h to use for invoking commands. This is intended to replace all current usage of virRun and virExec variants, with a more flexible and less error prone API. * src/util/command.c: New file. * src/util/command.h: New header. * src/Makefile.am (UTIL_SOURCES): Build it. * src/libvirt_private.syms: Export symbols internally. * tests/commandtest.c: New test. * tests/Makefile.am (check_PROGRAMS): Run it. * tests/commandhelper.c: Auxiliary program. * tests/commanddata/test2.log - test15.log: New expected outputs. * cfg.mk (useless_free_options): Add virCommandFree. (msg_gen_function): Add virCommandError. * po/POTFILES.in: New translation. * .x-sc_avoid_write: Add exemption. * tests/.gitignore: Ignore new built file.	2010-12-02 16:00:44 -07:00