2 Commits

Author	SHA1	Message	Date
Peter Krempa	002de683c6	conf: validate: Run global device definition validation before callbacks ... The validation infrastructure doesn't modify the definition and additionally it makes sense to run the global code first as it's validating certain corner cases. The changed error messages from qemuxml2argvtest show that this is indeed the proper ordering as all changed messages are actually better describing the error. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>	2021-09-09 10:17:28 +02:00
Sebastian Mitterle	9ec77eef2d	qemuxml2argvtest: Test expected error messages ... When an error is expected, the error message will be checked. This is expressed by creating an additional ".err" file containing the expected error message. It is added in order to make sure the expected errors are not masked by other errors during test execution while leveraging the existing framework. In order to keep it simple, an input file cannot be reused anymore to cover several expected error cases configured in the test code. An input file can still be reused by creating a test case specific symlink. For consistency, the mock needs to report an error now, too, as every failure must have an error; otherwise a test case will fail. Require LC_ALL=C explicitly to make sure error messages are not localized for testing. Signed-off-by: Sebastian Mitterle <smitterl@redhat.com> Suggested-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com>	2020-09-23 22:47:59 +02:00