shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00
Code Releases Activity
Libvirt native C API and daemons
28,194 Commits 67 Branches 629 Tags 668 MiB
C 94.8%
Python 2%
Meson 0.9%
Shell 0.8%
Dockerfile 0.6%
Other 0.8%
18c24bc686
Go to file
Laine Stump 18c24bc686 qemu: assign correct type of PCI address for vhost-scsi when using pcie-root 
Commit 10c73bf1 fixed a bug that I had introduced back in commit
70249927 - if a vhost-scsi device had no manually assigned PCI
address, one wouldn't be assigned automatically. There was a slight
problem with the logic of the fix though - in the case of domains with
pcie-root (e.g. those with a q35 machinetype),
qemuDomainDeviceCalculatePCIConnectFlags() will attempt to determine
if the host-side PCI device is Express or legacy by examining sysfs
based on the host-side PCI address stored in
hostdev->source.subsys.u.pci.addr, but that part of the union is only
valid for PCI hostdevs, *not* for SCSI hostdevs. So we end up trying
to read sysfs for some probably-non-existent device, which fails, and
the function virPCIDeviceIsPCIExpress() returns failure (-1).

By coincidence, the return value is being examined as a boolean, and
since -1 is true, we still end up assigning the vhost-scsi device to
an Express slot, but that is just by chance (and could fail in the
case that the gibberish in the "hostside PCI address" was the address
of a real device that happened to be legacy PCI).

Since (according to Paolo Bonzini) vhost-scsi devices appear just like
virtio-scsi devices in the guest, they should follow the same rules as
virtio devices when deciding whether they should be placed in an
Express or a legacy slot. That's accomplished in this patch by
returning early with virtioFlags, rather than erroneously using
hostdev->source.subsys.u.pci.addr. It also adds a test case for PCIe
to assure it doesn't get broken in the future.
2018-01-20 22:01:24 -05:00
.gnulib@7e7c5c7952 maint: update to latest gnulib 2018-01-03 15:48:14 -06:00
build-aux perl: Don't hardcode interpreter path 2017-09-19 16:04:53 +02:00
daemon rpc: Introduce virNetServerSetClientAuthenticated 2018-01-04 06:55:31 -05:00
docs Post-release version bump to 4.1.0 2018-01-19 14:26:53 +01:00
examples On startup libvirtd runs a number of QEMU processes unconfined such as: 2018-01-17 16:28:27 +01:00
gnulib build: drop hack for old mingw ssize_t 2016-07-12 08:57:13 -06:00
include/libvirt virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED 2017-12-07 14:30:20 +01:00
m4 Raise the frame limit for tests 2018-01-18 10:16:41 +01:00
po Release of libvirt-4.0.0 2018-01-19 11:43:00 +01:00
src qemu: assign correct type of PCI address for vhost-scsi when using pcie-root 2018-01-20 22:01:24 -05:00
tests qemu: assign correct type of PCI address for vhost-scsi when using pcie-root 2018-01-20 22:01:24 -05:00
tools tools: Always compile {virsh,virt-admin}-completer.c 2018-01-15 15:49:11 +01:00
.color_coded.in Add color_coded support 2017-05-09 09:51:11 +02:00
.ctags maint: Make ctags work out of the box 2013-07-18 08:47:21 +02:00
.dir-locals.el build: avoid tabs that failed syntax-check 2012-09-06 09:43:46 -06:00
.gitignore Add YouCompleteMe support 2017-05-09 09:51:11 +02:00
.gitmodules util: switch over to use keycodemapdb GIT submodule 2017-04-25 21:14:18 +01:00
.mailmap maint: update .mailmap for recent contributions 2015-03-20 06:17:55 -06:00
.travis.yml travis: Skip nfs-common installation 2018-01-12 14:40:58 +01:00
.ycm_extra_conf.py.in Add YouCompleteMe support 2017-05-09 09:51:11 +02:00
AUTHORS.in Change maintainers list 2016-02-12 13:10:05 +03:00
autogen.sh autogen.sh: tell user the correct make command 2017-12-18 17:03:51 +00:00
bootstrap maint: update to latest gnulib 2018-01-03 15:48:14 -06:00
bootstrap.conf hvsupport: use a regex instead of XML::XPath 2016-07-19 18:42:44 +02:00
cfg.mk cfg.mk: Simplify backslash alignment check 2017-12-15 13:38:39 +01:00
ChangeLog-old Fix typos in src/* 2014-04-21 16:49:08 -06:00
config-post.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
configure.ac Post-release version bump to 4.1.0 2018-01-19 14:26:53 +01:00
COPYING maint: follow recommended practice for using LGPL 2013-05-20 14:15:21 -06:00
COPYING.LESSER maint: Remove control characters from LGPL license file 2015-09-25 09:16:24 +02:00
libvirt-admin.pc.in Add libvirt-admin library 2015-06-16 13:46:20 +02:00
libvirt-lxc.pc.in Add pkg-config files for libvirt-qemu & libvirt-lxc 2014-06-23 16:17:27 +01:00
libvirt-qemu.pc.in Add pkg-config files for libvirt-qemu & libvirt-lxc 2014-06-23 16:17:27 +01:00
libvirt.pc.in Add pkg-config files for libvirt-qemu & libvirt-lxc 2014-06-23 16:17:27 +01:00
libvirt.spec.in rpm: updates wrt min required fedora version 2018-01-17 12:09:33 +00:00
Makefile.am Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
Makefile.nonreentrant Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
mingw-libvirt.spec.in Add libxslt as build requires for mingw RPMs 2017-09-04 13:05:24 +01:00
README Provide a useful README file 2017-05-22 17:01:37 +01:00
README-hacking HACKING: Drop from the git repository 2017-06-26 14:25:54 +02:00
README.md Add CII best practices badge 2017-10-13 16:08:01 +01:00
run.in Add PKG_CONFIG_PATH to run.in script. 2014-06-26 14:32:35 +01:00

README.md

Build Status CII Best Practices

Libvirt API for virtualization

Libvirt provides a portable, long term stable C API for managing the virtualization technologies provided by many operating systems. It includes support for QEMU, KVM, Xen, LXC, bhyve, Virtuozzo, VMware vCenter and ESX, VMware Desktop, Hyper-V, VirtualBox and the POWER Hypervisor.

For some of these hypervisors, it provides a stateful management daemon which runs on the virtualization host allowing access to the API both by non-privileged local users and remote users.

Layered packages provide bindings of the libvirt C API into other languages including Python, Perl, PHP, Go, Java, OCaml, as well as mappings into object systems such as GObject, CIM and SNMP.

Further information about the libvirt project can be found on the website:

https://libvirt.org

License

The libvirt C API is distributed under the terms of GNU Lesser General Public License, version 2.1 (or later). Some parts of the code that are not part of the C library may have the more restrictive GNU General Public License, version 2.1 (or later). See the files COPYING.LESSER and COPYING for full license terms & conditions.

Installation

Libvirt uses the GNU Autotools build system, so in general can be built and installed with the usual commands. For example, to build in a manner that is suitable for installing as root, use:

$ ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var
$ make
$ sudo make install

While to build & install as an unprivileged user

$ ./configure --prefix=$HOME/usr
$ make
$ make install

The libvirt code relies on a large number of 3rd party libraries. These will be detected during execution of the configure script and a summary printed which lists any missing (optional) dependencies.

Contributing

The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list. Further guidance on this can be found on the website:

https://libvirt.org/contribute.html

Contact

The libvirt project has two primary mailing lists:

Further details on contacting the project are available on the website:

https://libvirt.org/contact.html