mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 21:34:54 +03:00
397447f805
Jansson does not put a newline at the end of formatted JSON strings. This breaks the qemucapsprobe utility as we need to keep the spacing so that tests work. Add an explicit newline. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
128 lines
3.3 KiB
C
128 lines
3.3 KiB
C
/*
|
|
* Copyright (C) 2016 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Jiri Denemark <jdenemar@redhat.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <stdio.h>
|
|
#include <dlfcn.h>
|
|
|
|
#include "internal.h"
|
|
#include "viralloc.h"
|
|
#include "virjson.h"
|
|
#include "qemu/qemu_monitor.h"
|
|
#include "qemu/qemu_monitor_json.h"
|
|
|
|
#define REAL_SYM(realFunc) \
|
|
do { \
|
|
if (!realFunc && !(realFunc = dlsym(RTLD_NEXT, __FUNCTION__))) { \
|
|
fprintf(stderr, "Cannot find real '%s' symbol\n", \
|
|
__FUNCTION__); \
|
|
abort(); \
|
|
} \
|
|
} while (0)
|
|
|
|
static bool first = true;
|
|
|
|
static void
|
|
printLineSkipEmpty(const char *line,
|
|
FILE *fp)
|
|
{
|
|
const char *p;
|
|
|
|
for (p = line; *p; p++) {
|
|
if (p[0] == '\n' && p[1] == '\n')
|
|
continue;
|
|
|
|
fputc(*p, fp);
|
|
}
|
|
}
|
|
|
|
|
|
static int (*realQemuMonitorSend)(qemuMonitorPtr mon,
|
|
qemuMonitorMessagePtr msg);
|
|
|
|
int
|
|
qemuMonitorSend(qemuMonitorPtr mon,
|
|
qemuMonitorMessagePtr msg)
|
|
{
|
|
char *reformatted;
|
|
|
|
REAL_SYM(realQemuMonitorSend);
|
|
|
|
if (!(reformatted = virJSONStringReformat(msg->txBuffer, true))) {
|
|
fprintf(stderr, "Failed to reformat command string '%s'\n", msg->txBuffer);
|
|
abort();
|
|
}
|
|
|
|
if (first)
|
|
first = false;
|
|
else
|
|
printLineSkipEmpty("\n", stdout);
|
|
|
|
printLineSkipEmpty(reformatted, stdout);
|
|
printLineSkipEmpty("\n", stdout);
|
|
VIR_FREE(reformatted);
|
|
|
|
return realQemuMonitorSend(mon, msg);
|
|
}
|
|
|
|
|
|
static int (*realQemuMonitorJSONIOProcessLine)(qemuMonitorPtr mon,
|
|
const char *line,
|
|
qemuMonitorMessagePtr msg);
|
|
|
|
int
|
|
qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon,
|
|
const char *line,
|
|
qemuMonitorMessagePtr msg)
|
|
{
|
|
virJSONValuePtr value = NULL;
|
|
char *json = NULL;
|
|
int ret;
|
|
|
|
REAL_SYM(realQemuMonitorJSONIOProcessLine);
|
|
|
|
ret = realQemuMonitorJSONIOProcessLine(mon, line, msg);
|
|
|
|
if (ret == 0) {
|
|
if (!(value = virJSONValueFromString(line)) ||
|
|
!(json = virJSONValueToString(value, true))) {
|
|
fprintf(stderr, "Failed to reformat reply string '%s'\n", line);
|
|
abort();
|
|
}
|
|
|
|
/* Ignore QMP greeting */
|
|
if (virJSONValueObjectHasKey(value, "QMP"))
|
|
goto cleanup;
|
|
|
|
if (first)
|
|
first = false;
|
|
else
|
|
printLineSkipEmpty("\n", stdout);
|
|
|
|
printLineSkipEmpty(json, stdout);
|
|
printLineSkipEmpty("\n", stdout);
|
|
}
|
|
|
|
cleanup:
|
|
VIR_FREE(json);
|
|
virJSONValueFree(value);
|
|
return ret;
|
|
}
|