Peter Krempa f1c9fed2ca virsh: snapshot: Don't validate schema of XML generated by 'virsh snapshot-create-as' ... Commit 95f8e3237e which introduced XML schema validation for snapshot XMLs always asserted the validation for the XML generated by 'virsh snapshot-create-as' on the basis that it's libvirt-generated, thus valid. This unfortunately isn't true as users can influence certain bits of the XML such as the disk image path which must be a full path. Thus if a user tries to invoke virsh as: $ virsh snapshot-create-as upstream --diskspec vda,file=relative.qcow2 error: XML document failed to validate against schema: Unable to validate doc against /path/to/domainsnapshot.rng Extra element disks in interleave Element domainsnapshot failed to validate content They get a rather useless error from the libxml2 RNG validator. With this fix applied, we get to the XML parser in libvirtd which has a more reasonable error: $ virsh snapshot-create-as upstream --diskspec vda,file=relative.qcow2 error: XML error: disk snapshot image path 'relative.qcow2' must be absolute Instead users can force validation of the XML generated by 'virsh snapshot-create-as' by passing the '--validate' flag. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>		2021-04-16 17:27:39 +02:00
..
index.rst	docs: add manpage for virtxend	2021-01-15 19:08:00 +00:00
libvirtd.rst	docs: Document libxl.conf location	2021-03-12 10:52:51 +01:00
meson.build	docs: add manpage for virtxend	2021-01-15 19:08:00 +00:00
virsh.rst	virsh: snapshot: Don't validate schema of XML generated by 'virsh snapshot-create-as'	2021-04-16 17:27:39 +02:00
virt-admin.rst	docs: use "::" instead of ".. code-block::"	2020-10-05 13:05:47 +01:00
virt-host-validate.rst	docs: convert virt-host-validate man page from pod to rst	2019-12-11 14:28:41 +00:00
virt-login-shell.rst	docs: use "::" instead of ".. code-block::"	2020-10-05 13:05:47 +01:00
virt-pki-validate.rst	docs: convert virt-pki-validate man page from pod to rst	2019-12-11 14:28:41 +00:00
virt-qemu-run.rst	docs/drvqemu: Convert to RST	2021-04-06 17:00:11 +02:00
virt-sanlock-cleanup.rst	man: fix section of virt-sanlock-cleanup	2020-01-17 15:34:10 +01:00
virt-xml-validate.rst	docs: convert virt-xml-validate man page from pod to rst	2019-12-11 14:28:41 +00:00
virtbhyved.rst	docs: add manpage for virtbhyved	2021-01-15 19:08:00 +00:00
virtinterfaced.rst	docs: add manpage for virtinterfaced	2021-01-15 19:08:00 +00:00
virtlockd.rst	docs: don't hardcode an ancient version in manpage examples	2021-01-15 19:08:00 +00:00
virtlogd.rst	docs: don't hardcode an ancient version in manpage examples	2021-01-15 19:08:00 +00:00
virtlxcd.rst	docs: Document lxc.conf location	2021-03-12 10:52:41 +01:00
virtnetworkd.rst	docs: add manpage for virtnetworkd	2021-01-15 19:08:00 +00:00
virtnodedevd.rst	docs: add manpage for virtnodedevd	2021-01-15 19:08:00 +00:00
virtnwfilterd.rst	docs: add manpage for virtnwfilterd	2021-01-15 19:08:00 +00:00
virtproxyd.rst	Fix spelling	2021-04-15 15:42:21 +02:00
virtqemud.rst	docs: Capitalize QEMU driver reference	2021-03-12 10:51:47 +01:00
virtsecretd.rst	docs: add manpage for virtsecretd	2021-01-15 19:08:00 +00:00
virtstoraged.rst	docs: add manpage for virtstoraged	2021-01-15 19:08:00 +00:00
virtvboxd.rst	docs: add manpage for virtvboxd	2021-01-15 19:08:00 +00:00
virtvzd.rst	docs: add manpage for virtvzd	2021-01-15 19:08:00 +00:00
virtxend.rst	docs: Document libxl.conf location	2021-03-12 10:52:51 +01:00