mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-26 03:21:44 +03:00
7eb37a0d65
Recent autotest/virt-test testing on f20 discovered an anomaly in how the bandwidth options are documented and used. This was discovered due to a bug fix in the /sbin/tc utility found in iproute-3.11.0.1 (on f20) in which overflow was actually caught and returned as an error. The fix was first introduced in iproute-3.10 (search on iproute2 commit 'a303853e'). The autotest/virt-test test for virsh domiftune was attempting to send the largest unsigned integer value (4294967295) for maximum value testing. The libvirt xml implementation was designed to manage values in kilobytes thus when this value was passed to /sbin/tc, it (now) properly rejected the 4294967295kbps value. Investigation of the problem discovered that formatdomain.html.in and formatnetwork.html.in described the elements and property types slightly differently, although they use the same code - virNetDevBandwidthParseRate() (shared by portgroups, domains, and networks xml parsers). Rather than have the descriptions in two places, this patch will combine and reword the description under formatnetwork.html.in and have formatdomain.html.in link to that description. This documentation faux pas was continued into the virsh man page where the bandwidth description for both 'attach-interface' and 'domiftune' did not indicate the format of each value, thus leading to the test using largest unsigned integer value assuming "bps" rather than "kbps", which ultimately was wrong. |
||
|---|---|---|
| .. | ||
| wireshark | ||
| libvirt_win_icon_16x16.ico | ||
| libvirt_win_icon_32x32.ico | ||
| libvirt_win_icon_48x48.ico | ||
| libvirt_win_icon_64x64.ico | ||
| libvirt-guests.init.in | ||
| libvirt-guests.service.in | ||
| libvirt-guests.sh.in | ||
| libvirt-guests.sysconf | ||
| Makefile.am | ||
| virsh_win_icon.rc | ||
| virsh-console.c | ||
| virsh-console.h | ||
| virsh-domain-monitor.c | ||
| virsh-domain-monitor.h | ||
| virsh-domain.c | ||
| virsh-domain.h | ||
| virsh-edit.c | ||
| virsh-host.c | ||
| virsh-host.h | ||
| virsh-interface.c | ||
| virsh-interface.h | ||
| virsh-network.c | ||
| virsh-network.h | ||
| virsh-nodedev.c | ||
| virsh-nodedev.h | ||
| virsh-nwfilter.c | ||
| virsh-nwfilter.h | ||
| virsh-pool.c | ||
| virsh-pool.h | ||
| virsh-secret.c | ||
| virsh-secret.h | ||
| virsh-snapshot.c | ||
| virsh-snapshot.h | ||
| virsh-volume.c | ||
| virsh-volume.h | ||
| virsh.c | ||
| virsh.h | ||
| virsh.pod | ||
| virt-host-validate-common.c | ||
| virt-host-validate-common.h | ||
| virt-host-validate-lxc.c | ||
| virt-host-validate-lxc.h | ||
| virt-host-validate-qemu.c | ||
| virt-host-validate-qemu.h | ||
| virt-host-validate.c | ||
| virt-login-shell.c | ||
| virt-login-shell.conf | ||
| virt-login-shell.pod | ||
| virt-pki-validate.in | ||
| virt-sanlock-cleanup.in | ||
| virt-xml-validate.in | ||