mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 21:34:54 +03:00
98f1f4a439
In testXLInitDriver() a dummy driver structure is filled and it is freed later in testXLFreeDriver(). However, it is sufficient to unref just driver->config because that results in libxlDriverConfigDispose() being called which unrefs driver->config->caps. There is no need to unref it again in testXLFreeDriver() - in fact it's undesired. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
113 lines
3.5 KiB
C
113 lines
3.5 KiB
C
#include <config.h>
|
|
|
|
#include <sys/utsname.h>
|
|
|
|
#include "testutilsxen.h"
|
|
#include "testutilshostcpus.h"
|
|
#include "domain_conf.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_LIBXL
|
|
|
|
static virCapsPtr
|
|
testXLInitCaps(void)
|
|
{
|
|
virCapsPtr caps;
|
|
virCapsGuestPtr guest;
|
|
virCapsGuestMachinePtr *machines;
|
|
int nmachines;
|
|
static const char *const x86_machines[] = {
|
|
"xenfv"
|
|
};
|
|
static const char *const xen_machines[] = {
|
|
"xenpv",
|
|
};
|
|
static const char *const pvh_machines[] = {
|
|
"xenpvh",
|
|
};
|
|
|
|
if ((caps = virCapabilitiesNew(virArchFromHost(),
|
|
false, false)) == NULL)
|
|
return NULL;
|
|
|
|
caps->host.cpu = virCPUDefCopy(&cpuDefaultData);
|
|
|
|
nmachines = G_N_ELEMENTS(x86_machines);
|
|
if ((machines = virCapabilitiesAllocMachines(x86_machines, nmachines)) == NULL)
|
|
goto cleanup;
|
|
if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM,
|
|
VIR_ARCH_X86_64,
|
|
"/usr/lib/xen/bin/qemu-system-i386",
|
|
"/usr/lib/xen/boot/hvmloader",
|
|
nmachines, machines)) == NULL)
|
|
goto cleanup;
|
|
machines = NULL;
|
|
if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_XEN, NULL,
|
|
NULL, 0, NULL) == NULL)
|
|
goto cleanup;
|
|
nmachines = G_N_ELEMENTS(xen_machines);
|
|
if ((machines = virCapabilitiesAllocMachines(xen_machines, nmachines)) == NULL)
|
|
goto cleanup;
|
|
|
|
if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_XEN,
|
|
VIR_ARCH_X86_64,
|
|
"/usr/lib/xen/bin/qemu-system-i386",
|
|
NULL,
|
|
nmachines, machines)) == NULL)
|
|
goto cleanup;
|
|
machines = NULL;
|
|
|
|
if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_XEN, NULL,
|
|
NULL, 0, NULL) == NULL)
|
|
goto cleanup;
|
|
nmachines = G_N_ELEMENTS(pvh_machines);
|
|
if ((machines = virCapabilitiesAllocMachines(pvh_machines, nmachines)) == NULL)
|
|
goto cleanup;
|
|
|
|
if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_XENPVH,
|
|
VIR_ARCH_X86_64,
|
|
"/usr/lib/xen/bin/qemu-system-i386",
|
|
NULL,
|
|
nmachines, machines)) == NULL)
|
|
goto cleanup;
|
|
machines = NULL;
|
|
|
|
if (virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_XEN, NULL,
|
|
NULL, 0, NULL) == NULL)
|
|
goto cleanup;
|
|
return caps;
|
|
|
|
cleanup:
|
|
virCapabilitiesFreeMachines(machines, nmachines);
|
|
virObjectUnref(caps);
|
|
return NULL;
|
|
}
|
|
|
|
|
|
libxlDriverPrivatePtr testXLInitDriver(void)
|
|
{
|
|
libxlDriverPrivatePtr driver = g_new0(libxlDriverPrivate, 1);
|
|
|
|
if (virMutexInit(&driver->lock) < 0) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"%s", "cannot initialize mutex");
|
|
g_free(driver);
|
|
return NULL;
|
|
}
|
|
|
|
driver->config = libxlDriverConfigNew();
|
|
|
|
driver->config->caps = testXLInitCaps();
|
|
|
|
driver->xmlopt = libxlCreateXMLConf(driver);
|
|
|
|
return driver;
|
|
}
|
|
|
|
void testXLFreeDriver(libxlDriverPrivatePtr driver)
|
|
{
|
|
virObjectUnref(driver->config);
|
|
virObjectUnref(driver->xmlopt);
|
|
virMutexDestroy(&driver->lock);
|
|
g_free(driver);
|
|
}
|