mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-12-14 04:24:19 +03:00
d74928fed3
The API was apparently never considered for being used on a host that is not represented in the input set of CPU definitions. The result is limited to the set of features and CPU models known to the host's hypervisor. This would likely not be a big issue, but thanks to a side effect of commit v3.8.0-99-g9c9620af1d usability blockers come to play as well. When converting CPU data (CPUID and MSR bits) to each named model for comparison, we disable features that block usability of the model on the current hypervisor, the rest of the features are set according to the data without taking host capabilities into account. Thus the process of comparing and selecting the most appropriate CPU model for the given data is significantly influenced by the host, but it doesn't behave as if the host CPU model was included in the input data. The documentation tried to say the result was tied to the host's hypervisor, but it wasn't very clear. Signed-off-by: Jiri Denemark <jdenemar@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>