mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 17:34:18 +03:00
600462834f
In many files there are header comments that contain an Author: statement, supposedly reflecting who originally wrote the code. In a large collaborative project like libvirt, any non-trivial file will have been modified by a large number of different contributors. IOW, the Author: comments are quickly out of date, omitting people who have made significant contribitions. In some places Author: lines have been added despite the person merely being responsible for creating the file by moving existing code out of another file. IOW, the Author: lines give an incorrect record of authorship. With this all in mind, the comments are useless as a means to identify who to talk to about code in a particular file. Contributors will always be better off using 'git log' and 'git blame' if they need to find the author of a particular bit of code. This commit thus deletes all Author: comments from the source and adds a rule to prevent them reappearing. The Copyright headers are similarly misleading and inaccurate, however, we cannot delete these as they have legal meaning, despite being largely inaccurate. In addition only the copyright holder is permitted to change their respective copyright statement. Reviewed-by: Erik Skultety <eskultet@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
139 lines
3.8 KiB
C
139 lines
3.8 KiB
C
/*
|
|
* Copyright (C) 2012, 2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <signal.h>
|
|
|
|
#include "testutils.h"
|
|
#include "virerror.h"
|
|
#include "viralloc.h"
|
|
#include "virlog.h"
|
|
|
|
#include "virauthconfig.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_RPC
|
|
|
|
VIR_LOG_INIT("tests.authconfigtest");
|
|
|
|
struct ConfigLookupData {
|
|
virAuthConfigPtr config;
|
|
const char *hostname;
|
|
const char *service;
|
|
const char *credname;
|
|
const char *expect;
|
|
};
|
|
|
|
static int testAuthLookup(const void *args)
|
|
{
|
|
int ret = -1;
|
|
const struct ConfigLookupData *data = args;
|
|
const char *actual = NULL;
|
|
int rv;
|
|
|
|
rv = virAuthConfigLookup(data->config,
|
|
data->service,
|
|
data->hostname,
|
|
data->credname,
|
|
&actual);
|
|
|
|
if (rv < 0)
|
|
goto cleanup;
|
|
|
|
if (data->expect) {
|
|
if (!actual ||
|
|
STRNEQ(actual, data->expect)) {
|
|
VIR_WARN("Expected value '%s' for '%s' '%s' '%s', but got '%s'",
|
|
data->expect, data->hostname,
|
|
data->service, data->credname,
|
|
NULLSTR(actual));
|
|
goto cleanup;
|
|
}
|
|
} else {
|
|
if (actual) {
|
|
VIR_WARN("Did not expect a value for '%s' '%s' '%s', but got '%s'",
|
|
data->hostname,
|
|
data->service, data->credname,
|
|
actual);
|
|
goto cleanup;
|
|
}
|
|
}
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
virAuthConfigPtr config;
|
|
|
|
signal(SIGPIPE, SIG_IGN);
|
|
|
|
#define TEST_LOOKUP(config, hostname, service, credname, expect) \
|
|
do { \
|
|
const struct ConfigLookupData data = { \
|
|
config, hostname, service, credname, expect \
|
|
}; \
|
|
if (virTestRun("Test Lookup " hostname "-" service "-" credname, \
|
|
testAuthLookup, &data) < 0) \
|
|
ret = -1; \
|
|
} while (0)
|
|
|
|
const char *confdata =
|
|
"[credentials-test]\n"
|
|
"username=fred\n"
|
|
"password=123456\n"
|
|
"\n"
|
|
"[credentials-prod]\n"
|
|
"username=bar\n"
|
|
"password=letmein\n"
|
|
"\n"
|
|
"[auth-libvirt-test1.example.com]\n"
|
|
"credentials=test\n"
|
|
"\n"
|
|
"[auth-libvirt-test2.example.com]\n"
|
|
"credentials=test\n"
|
|
"\n"
|
|
"[auth-libvirt-demo3.example.com]\n"
|
|
"credentials=test\n"
|
|
"\n"
|
|
"[auth-libvirt-prod1.example.com]\n"
|
|
"credentials=prod\n";
|
|
|
|
if (!(config = virAuthConfigNewData("auth.conf", confdata, strlen(confdata))))
|
|
return EXIT_FAILURE;
|
|
|
|
TEST_LOOKUP(config, "test1.example.com", "libvirt", "username", "fred");
|
|
TEST_LOOKUP(config, "test1.example.com", "vnc", "username", NULL);
|
|
TEST_LOOKUP(config, "test1.example.com", "libvirt", "realm", NULL);
|
|
TEST_LOOKUP(config, "test66.example.com", "libvirt", "username", NULL);
|
|
TEST_LOOKUP(config, "prod1.example.com", "libvirt", "username", "bar");
|
|
TEST_LOOKUP(config, "prod1.example.com", "libvirt", "password", "letmein");
|
|
|
|
virAuthConfigFree(config);
|
|
|
|
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIR_TEST_MAIN(mymain)
|