dict: Compare strings with strncmp

Using memcmp can result in OOB reads. Short-lived regression found by OSS-Fuzz.
2024-12-24 21:33:51 +03:00 · 2023-10-02 14:42:51 +02:00 · 2023-10-02 14:42:51 +02:00 · 71aae4e98b
commit 71aae4e98b
parent eb69c1d39d
1 changed files with 2 additions and 1 deletions
--- a/dict.c
+++ b/dict.c
@ -538,7 +538,8 @@ xmlDictFindEntry(const xmlDict *dict, const xmlChar *prefix,
                    /*
                     * name is not necessarily null-terminated.
                     */
-                    if ((memcmp(entry->name, name, len) == 0) &&
+                    if ((strncmp((const char *) entry->name,
+                                 (const char *) name, len) == 0) &&
                        (entry->name[len] == 0)) {
                        found = 1;
                        break;