shaba/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2.git synced 2024-12-24 21:33:51 +03:00
Code

dict: Compare strings with strncmp

Browse Source 
Using memcmp can result in OOB reads.

Short-lived regression found by OSS-Fuzz.
This commit is contained in:
Nick Wellnhofer 2023-10-02 14:42:51 +02:00
parent eb69c1d39d
commit 71aae4e98b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dict.c
View File

@ -538,7 +538,8 @@ xmlDictFindEntry(const xmlDict *dict, const xmlChar *prefix,
/* /*
* name is not necessarily null-terminated. * name is not necessarily null-terminated.
*/ */
if ((memcmp(entry->name, name, len) == 0) && if ((strncmp((const char *) entry->name,
(const char *) name, len) == 0) &&
(entry->name[len] == 0)) { (entry->name[len] == 0)) {
found = 1; found = 1;
break; break;