shaba/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2.git synced 2025-04-25 22:50:08 +03:00
Code

parser: Remove useless ent->etype test in xmlParseReference

Browse Source 
If ent->etype is invalid, ret can't equal XML_ERR_OK.
This commit is contained in:
Nick Wellnhofer 2022-12-20 03:09:11 +01:00
parent 7ee7f0360a
commit ec6633afae
1 changed files with 33 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
parser.c
View File

@ -7271,8 +7271,6 @@ xmlParseReference(xmlParserCtxtPtr ctxt) {
} }
if ((ret == XML_ERR_OK) && (list != NULL)) { if ((ret == XML_ERR_OK) && (list != NULL)) {
if ((ent->etype == XML_INTERNAL_GENERAL_ENTITY) ||
(ent->etype == XML_EXTERNAL_GENERAL_PARSED_ENTITY)) {
ent->children = list; ent->children = list;
/* /*
* Prune it directly in the generated document * Prune it directly in the generated document
@ -7307,10 +7305,6 @@ xmlParseReference(xmlParserCtxtPtr ctxt) {
xmlAddEntityReference(ent, list, NULL); xmlAddEntityReference(ent, list, NULL);
#endif /* LIBXML_LEGACY_ENABLED */ #endif /* LIBXML_LEGACY_ENABLED */
} }
} else {
xmlFreeNodeList(list);
list = NULL;
}
} else if ((ret != XML_ERR_OK) && } else if ((ret != XML_ERR_OK) &&
(ret != XML_WAR_UNDECLARED_ENTITY)) { (ret != XML_WAR_UNDECLARED_ENTITY)) {
xmlFatalErrMsgStr(ctxt, XML_ERR_UNDECLARED_ENTITY, xmlFatalErrMsgStr(ctxt, XML_ERR_UNDECLARED_ENTITY,