2001-10-16 02:04:27 +04:00
/*
2008-01-30 17:00:02 +03:00
* Copyright ( C ) 2001 - 2004 Sistina Software , Inc . All rights reserved .
2009-05-13 17:02:52 +04:00
* Copyright ( C ) 2004 - 2009 Red Hat , Inc . All rights reserved .
2001-10-16 02:04:27 +04:00
*
2004-03-30 23:35:44 +04:00
* This file is part of LVM2 .
2001-10-16 02:04:27 +04:00
*
2004-03-30 23:35:44 +04:00
* This copyrighted material is made available to anyone wishing to use ,
* modify , copy , or redistribute it subject to the terms and conditions
2007-08-21 00:55:30 +04:00
* of the GNU Lesser General Public License v .2 .1 .
2001-10-16 02:04:27 +04:00
*
2007-08-21 00:55:30 +04:00
* You should have received a copy of the GNU Lesser General Public License
2004-03-30 23:35:44 +04:00
* along with this program ; if not , write to the Free Software Foundation ,
2016-01-21 13:49:46 +03:00
* Inc . , 51 Franklin Street , Fifth Floor , Boston , MA 02110 - 1301 USA
2001-10-16 02:04:27 +04:00
*/
# include "tools.h"
2015-02-13 17:58:51 +03:00
struct vgextend_params {
2016-02-19 00:38:23 +03:00
struct pvcreate_params pp ;
2015-02-13 17:58:51 +03:00
} ;
static int _restore_pv ( struct volume_group * vg , const char * pv_name )
2010-10-13 14:34:31 +04:00
{
struct pv_list * pvl = NULL ;
pvl = find_pv_in_vg ( vg , pv_name ) ;
if ( ! pvl ) {
log_warn ( " WARNING: PV %s not found in VG %s " , pv_name , vg - > name ) ;
return 0 ;
}
if ( ! ( pvl - > pv - > status & MISSING_PV ) ) {
log_warn ( " WARNING: PV %s was not missing in VG %s " , pv_name , vg - > name ) ;
return 0 ;
}
if ( ! pvl - > pv - > dev ) {
log_warn ( " WARNING: The PV %s is still missing. " , pv_name ) ;
return 0 ;
}
pvl - > pv - > status & = ~ MISSING_PV ;
return 1 ;
}
2015-02-13 17:58:51 +03:00
static int _vgextend_restoremissing ( struct cmd_context * cmd __attribute__ ( ( unused ) ) ,
const char * vg_name , struct volume_group * vg ,
struct processing_handle * handle )
{
struct vgextend_params * vp = ( struct vgextend_params * ) handle - > custom_handle ;
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp = & vp - > pp ;
2015-02-13 17:58:51 +03:00
int fixed = 0 ;
2017-02-12 20:18:54 +03:00
unsigned i ;
2015-02-13 17:58:51 +03:00
2015-12-03 20:15:02 +03:00
if ( ! archive ( vg ) )
return_0 ;
2016-02-15 23:28:09 +03:00
for ( i = 0 ; i < pp - > pv_count ; i + + )
if ( _restore_pv ( vg , pp - > pv_names [ i ] ) )
2015-02-13 17:58:51 +03:00
fixed + + ;
if ( ! fixed ) {
log_error ( " No PV has been restored. " ) ;
return ECMD_FAILED ;
}
if ( ! vg_write ( vg ) | | ! vg_commit ( vg ) )
return_ECMD_FAILED ;
backup ( vg ) ;
log_print_unless_silent ( " Volume group \" %s \" successfully extended " , vg_name ) ;
return ECMD_PROCESSED ;
}
static int _vgextend_single ( struct cmd_context * cmd , const char * vg_name ,
struct volume_group * vg , struct processing_handle * handle )
{
struct vgextend_params * vp = ( struct vgextend_params * ) handle - > custom_handle ;
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp = & vp - > pp ;
2015-02-13 17:58:51 +03:00
uint32_t mda_copies ;
uint32_t mda_used ;
int ret = ECMD_FAILED ;
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , metadataignore_ARG ) & &
2015-02-13 17:58:51 +03:00
( pp - > force = = PROMPT ) & & ! pp - > yes & &
( vg_mda_copies ( vg ) ! = VGMETADATACOPIES_UNMANAGED ) & &
( yes_no_prompt ( " Override preferred number of copies of VG %s metadata? [y/n]: " , vg_name ) = = ' n ' ) ) {
log_error ( " Volume group %s not changed " , vg_name ) ;
return ECMD_FAILED ;
}
2015-12-03 20:15:02 +03:00
if ( ! archive ( vg ) )
return_ECMD_FAILED ;
2016-02-15 23:28:09 +03:00
if ( ! vg_extend_each_pv ( vg , pp ) )
2015-02-13 17:58:51 +03:00
goto_out ;
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , metadataignore_ARG ) ) {
2015-02-13 17:58:51 +03:00
mda_copies = vg_mda_copies ( vg ) ;
mda_used = vg_mda_used_count ( vg ) ;
if ( ( mda_copies ! = VGMETADATACOPIES_UNMANAGED ) & &
( mda_copies ! = mda_used ) ) {
log_warn ( " WARNING: Changing preferred number of copies of VG %s metadata from % " PRIu32 " to % " PRIu32 ,
vg_name , mda_copies , mda_used ) ;
vg_set_mda_copies ( vg , mda_used ) ;
}
}
2016-02-15 23:28:09 +03:00
log_verbose ( " Volume group \" %s \" will be extended by %d new physical volumes " , vg_name , pp - > pv_count ) ;
2015-02-13 17:58:51 +03:00
if ( ! vg_write ( vg ) | | ! vg_commit ( vg ) )
goto_out ;
backup ( vg ) ;
log_print_unless_silent ( " Volume group \" %s \" successfully extended " , vg_name ) ;
ret = ECMD_PROCESSED ;
out :
return ret ;
}
2002-02-11 23:50:53 +03:00
int vgextend ( struct cmd_context * cmd , int argc , char * * argv )
2001-10-16 02:04:27 +04:00
{
2016-02-15 23:28:09 +03:00
struct processing_handle * handle ;
2015-02-13 17:58:51 +03:00
struct vgextend_params vp ;
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp = & vp . pp ;
2015-02-13 17:58:51 +03:00
unsigned restoremissing = arg_is_set ( cmd , restoremissing_ARG ) ;
2016-02-15 23:28:09 +03:00
const char * vg_name ;
2015-02-13 17:58:51 +03:00
int ret ;
2001-10-16 02:04:27 +04:00
if ( ! argc ) {
log_error ( " Please enter volume group name and "
2002-02-12 00:00:35 +03:00
" physical volume(s) " ) ;
2001-10-16 02:04:27 +04:00
return EINVALID_CMD_LINE ;
}
2016-02-15 23:28:09 +03:00
vg_name = skip_dev_dir ( cmd , argv [ 0 ] , NULL ) ;
argc - - ;
argv + + ;
2015-02-13 17:58:51 +03:00
2016-02-19 00:38:23 +03:00
pvcreate_params_set_defaults ( pp ) ;
2015-02-13 17:58:51 +03:00
2016-02-19 00:38:23 +03:00
if ( ! pvcreate_params_from_args ( cmd , pp ) )
2016-02-15 23:28:09 +03:00
return EINVALID_CMD_LINE ;
2015-02-13 17:58:51 +03:00
2016-02-15 23:28:09 +03:00
pp - > pv_count = argc ;
pp - > pv_names = argv ;
/* Don't create a new PV on top of an existing PV like pvcreate does. */
pp - > preserve_existing = 1 ;
/* pvcreate within vgextend cannot be forced. */
pp - > force = 0 ;
locking: unify global lock for flock and lockd
There have been two file locks used to protect lvm
"global state": "ORPHANS" and "GLOBAL".
Commands that used the ORPHAN flock in exclusive mode:
pvcreate, pvremove, vgcreate, vgextend, vgremove,
vgcfgrestore
Commands that used the ORPHAN flock in shared mode:
vgimportclone, pvs, pvscan, pvresize, pvmove,
pvdisplay, pvchange, fullreport
Commands that used the GLOBAL flock in exclusive mode:
pvchange, pvscan, vgimportclone, vgscan
Commands that used the GLOBAL flock in shared mode:
pvscan --cache, pvs
The ORPHAN lock covers the important cases of serializing
the use of orphan PVs. It also partially covers the
reporting of orphan PVs (although not correctly as
explained below.)
The GLOBAL lock doesn't seem to have a clear purpose
(it may have eroded over time.)
Neither lock correctly protects the VG namespace, or
orphan PV properties.
To simplify and correct these issues, the two separate
flocks are combined into the one GLOBAL flock, and this flock
is used from the locking sites that are in place for the
lvmlockd global lock.
The logic behind the lvmlockd (distributed) global lock is
that any command that changes "global state" needs to take
the global lock in ex mode. Global state in lvm is: the list
of VG names, the set of orphan PVs, and any properties of
orphan PVs. Reading this global state can use the global lock
in sh mode to ensure it doesn't change while being reported.
The locking of global state now looks like:
lockd_global()
previously named lockd_gl(), acquires the distributed
global lock through lvmlockd. This is unchanged.
It serializes distributed lvm commands that are changing
global state. This is a no-op when lvmlockd is not in use.
lockf_global()
acquires an flock on a local file. It serializes local lvm
commands that are changing global state.
lock_global()
first calls lockf_global() to acquire the local flock for
global state, and if this succeeds, it calls lockd_global()
to acquire the distributed lock for global state.
Replace instances of lockd_gl() with lock_global(), so that the
existing sites for lvmlockd global state locking are now also
used for local file locking of global state. Remove the previous
file locking calls lock_vol(GLOBAL) and lock_vol(ORPHAN).
The following commands which change global state are now
serialized with the exclusive global flock:
pvchange (of orphan), pvresize (of orphan), pvcreate, pvremove,
vgcreate, vgextend, vgremove, vgreduce, vgrename,
vgcfgrestore, vgimportclone, vgmerge, vgsplit
Commands that use a shared flock to read global state (and will
be serialized against the prior list) are those that use
process_each functions that are based on processing a list of
all VG names, or all PVs. The list of all VGs or all PVs is
global state and the shared lock prevents those lists from
changing while the command is processing them.
The ORPHAN lock previously attempted to produce an accurate
listing of orphan PVs, but it was only acquired at the end of
the command during the fake vg_read of the fake orphan vg.
This is not when orphan PVs were determined; they were
determined by elimination beforehand by processing all real
VGs, and subtracting the PVs in the real VGs from the list
of all PVs that had been identified during the initial scan.
This is fixed by holding the single global lock in shared mode
while processing all VGs to determine the list of orphan PVs.
2019-04-18 23:01:19 +03:00
if ( ! lock_global ( cmd , " ex " ) )
2016-02-15 23:28:09 +03:00
return_ECMD_FAILED ;
2018-12-07 23:35:22 +03:00
clear_hint_file ( cmd ) ;
2019-04-30 22:10:27 +03:00
lvmcache_label_scan ( cmd ) ;
2016-05-31 13:24:05 +03:00
if ( ! ( handle = init_processing_handle ( cmd , NULL ) ) ) {
2016-02-15 23:28:09 +03:00
log_error ( " Failed to initialize processing handle. " ) ;
return ECMD_FAILED ;
}
if ( ! restoremissing ) {
if ( ! pvcreate_each_device ( cmd , handle , pp ) ) {
destroy_processing_handle ( cmd , handle ) ;
return_ECMD_FAILED ;
}
}
2012-07-27 02:06:06 +04:00
/*
* It is always ok to add new PVs to a VG - even if there are
* missing PVs . No LVs are affected by this operation , but
* repair processes - particularly for RAID segtypes - can
* be facilitated .
*/
cmd - > handles_missing_pvs = 1 ;
2010-10-13 14:34:31 +04:00
2016-02-15 23:28:09 +03:00
handle - > custom_handle = & vp ;
2015-03-05 23:00:44 +03:00
2016-04-29 00:18:20 +03:00
ret = process_each_vg ( cmd , 0 , NULL , vg_name , NULL ,
2019-04-30 22:10:27 +03:00
READ_FOR_UPDATE | PROCESS_SKIP_SCAN , 0 , handle ,
2015-02-13 17:58:51 +03:00
restoremissing ? & _vgextend_restoremissing : & _vgextend_single ) ;
2010-07-07 23:02:50 +04:00
2015-02-13 17:58:51 +03:00
destroy_processing_handle ( cmd , handle ) ;
2001-10-16 02:04:27 +04:00
2015-02-13 17:58:51 +03:00
return ret ;
2001-10-16 02:04:27 +04:00
}