shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-22 17:35:59 +03:00
Code Releases Activity
9966842810
lvm2/lib/report/properties.c

474 lines
17 KiB
C
Raw Normal View History

Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
/*
Thin add new display field for lvs New field Data% is able to display info about thin_pool, thin, snapshot and has generic meaning here. Simple Time/Host field are here to display host and time creation.
2012-01-19 19:34:32 +04:00
* Copyright (C) 2010-2012 Red Hat, Inc. All rights reserved.
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
*
* This file is part of LVM2.
*
* This copyrighted material is made available to anyone wishing to use,
* modify, copy, or redistribute it subject to the terms and conditions
* of the GNU Lesser General Public License v.2.1.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
#include <errno.h>
#include "libdevmapper.h"
#include "properties.h"
Add getters for copy_percent and snap_percent to the lvm2app API.
2010-12-15 02:20:58 +03:00
#include "activate.h"
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
#include "lvm-logging.h"
#include "lvm-types.h"
#include "metadata.h"
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
#define GET_NUM_PROPERTY_FN(NAME, VALUE, TYPE, VAR) \
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
static int _ ## NAME ## _get (const void *obj, struct lvm_property_type *prop) \
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 17:02:39 +04:00
{ \
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
const struct TYPE *VAR = (const struct TYPE *)obj; \
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 17:02:39 +04:00
\
Rename fields in lvm_property_type. Based on review comments, rename a few fields in lvm_property_type. In particular, change 'is_writeable' to 'is_settable', which is more intuitive to the intent of the bitfield (a 'set' function exists for this field/property). Also, remove the char array for 'id' - unnecessary as we can just use the string passed in to do the strcmp. Finally rename the union members from n_val to 'integer' and 's_val' to 'string'.
2010-10-21 18:49:43 +04:00
prop->value.integer = VALUE; \
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 17:02:39 +04:00
return 1; \
}
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
#define GET_VG_NUM_PROPERTY_FN(NAME, VALUE) \
GET_NUM_PROPERTY_FN(NAME, VALUE, volume_group, vg)
#define GET_PV_NUM_PROPERTY_FN(NAME, VALUE) \
GET_NUM_PROPERTY_FN(NAME, VALUE, physical_volume, pv)
#define GET_LV_NUM_PROPERTY_FN(NAME, VALUE) \
GET_NUM_PROPERTY_FN(NAME, VALUE, logical_volume, lv)
Add the macro and specific 'get' functions for lvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:08:14 +03:00
#define GET_LVSEG_NUM_PROPERTY_FN(NAME, VALUE) \
GET_NUM_PROPERTY_FN(NAME, VALUE, lv_segment, lvseg)
Add the macro and specific 'get' functions for pvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:11:27 +03:00
#define GET_PVSEG_NUM_PROPERTY_FN(NAME, VALUE) \
GET_NUM_PROPERTY_FN(NAME, VALUE, pv_segment, pvseg)
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
Add generic infrastructure to internal library to 'set' a property. Similar to 'get' property internal functions. Add specific 'set' function for vg_mda_copies. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 22:15:10 +03:00
#define SET_NUM_PROPERTY_FN(NAME, SETFN, TYPE, VAR) \
static int _ ## NAME ## _set (void *obj, struct lvm_property_type *prop) \
{ \
struct TYPE *VAR = (struct TYPE *)obj; \
\
SETFN(VAR, prop->value.integer); \
return 1; \
}
#define SET_VG_NUM_PROPERTY_FN(NAME, SETFN) \
SET_NUM_PROPERTY_FN(NAME, SETFN, volume_group, vg)
#define SET_PV_NUM_PROPERTY_FN(NAME, SETFN) \
SET_NUM_PROPERTY_FN(NAME, SETFN, physical_volume, pv)
#define SET_LV_NUM_PROPERTY_FN(NAME, SETFN) \
SET_NUM_PROPERTY_FN(NAME, SETFN, logical_volume, lv)
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
#define GET_STR_PROPERTY_FN(NAME, VALUE, TYPE, VAR) \
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
static int _ ## NAME ## _get (const void *obj, struct lvm_property_type *prop) \
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
{ \
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
const struct TYPE *VAR = (const struct TYPE *)obj; \
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
\
Rename fields in lvm_property_type. Based on review comments, rename a few fields in lvm_property_type. In particular, change 'is_writeable' to 'is_settable', which is more intuitive to the intent of the bitfield (a 'set' function exists for this field/property). Also, remove the char array for 'id' - unnecessary as we can just use the string passed in to do the strcmp. Finally rename the union members from n_val to 'integer' and 's_val' to 'string'.
2010-10-21 18:49:43 +04:00
prop->value.string = (char *)VALUE; \
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
return 1; \
}
#define GET_VG_STR_PROPERTY_FN(NAME, VALUE) \
GET_STR_PROPERTY_FN(NAME, VALUE, volume_group, vg)
#define GET_PV_STR_PROPERTY_FN(NAME, VALUE) \
GET_STR_PROPERTY_FN(NAME, VALUE, physical_volume, pv)
#define GET_LV_STR_PROPERTY_FN(NAME, VALUE) \
GET_STR_PROPERTY_FN(NAME, VALUE, logical_volume, lv)
Add the macro and specific 'get' functions for lvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:08:14 +03:00
#define GET_LVSEG_STR_PROPERTY_FN(NAME, VALUE) \
GET_STR_PROPERTY_FN(NAME, VALUE, lv_segment, lvseg)
Add the macro and specific 'get' functions for pvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:11:27 +03:00
#define GET_PVSEG_STR_PROPERTY_FN(NAME, VALUE) \
GET_STR_PROPERTY_FN(NAME, VALUE, pv_segment, pvseg)
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 17:02:39 +04:00
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
static int _not_implemented_get(const void *obj, struct lvm_property_type *prop)
{
log_errno(ENOSYS, "Function not implemented");
return 0;
}
static int _not_implemented_set(void *obj, struct lvm_property_type *prop)
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
{
log_errno(ENOSYS, "Function not implemented");
return 0;
}
Add getters for copy_percent and snap_percent to the lvm2app API.
2010-12-15 02:20:58 +03:00
static percent_t _copy_percent(const struct logical_volume *lv) {
Return PERCENT_INVALID for error case If the percent value could not be determined return PERCENT_INVALID. Indent function with tabs.
2011-01-05 15:33:51 +03:00
percent_t perc;
Const fixing Fixing some const warnings - with API change in: int vg_extend(struct volume_group *vg, int pv_count, const char *const *pv_names, Change is needed - as lvm2api expects const behaviour here. So vg_extend() is doing local strdup for unescaping. skip_dev_dir return const char* from const char* vg_name. Rest of the patch is cleanup of related warnings. Also using dm_report_filed_string() API change to simplify casting in _string_disp and _lvname_disp.
2011-02-18 17:47:28 +03:00
if (!lv_mirror_percent(lv->vg->cmd, lv, 0, &perc, NULL))
Return PERCENT_INVALID for error case If the percent value could not be determined return PERCENT_INVALID. Indent function with tabs.
2011-01-05 15:33:51 +03:00
perc = PERCENT_INVALID;
return perc;
Add getters for copy_percent and snap_percent to the lvm2app API.
2010-12-15 02:20:58 +03:00
}
RAID: Add scrubbing support for RAID LVs New options to 'lvchange' allow users to scrub their RAID LVs. Synopsis: lvchange --syncaction {check|repair} vg/raid_lv RAID scrubbing is the process of reading all the data and parity blocks in an array and checking to see whether they are coherent. 'lvchange' can now initaite the two scrubbing operations: "check" and "repair". "check" will go over the array and recored the number of discrepancies but not repair them. "repair" will correct the discrepancies as it finds them. 'lvchange --syncaction repair vg/raid_lv' is not to be confused with 'lvconvert --repair vg/raid_lv'. The former initiates a background synchronization operation on the array, while the latter is designed to repair/replace failed devices in a mirror or RAID logical volume. Additional reporting has been added for 'lvs' to support the new operations. Two new printable fields (which are not printed by default) have been added: "syncaction" and "mismatches". These can be accessed using the '-o' option to 'lvs', like: lvs -o +syncaction,mismatches vg/lv "syncaction" will print the current synchronization operation that the RAID volume is performing. It can be one of the following: - idle: All sync operations complete (doing nothing) - resync: Initializing an array or recovering after a machine failure - recover: Replacing a device in the array - check: Looking for array inconsistencies - repair: Looking for and repairing inconsistencies The "mismatches" field with print the number of descrepancies found during a check or repair operation. The 'Cpy%Sync' field already available to 'lvs' will print the progress of any of the above syncactions, including check and repair. Finally, the lv_attr field has changed to accomadate the scrubbing operations as well. The role of the 'p'artial character in the lv_attr report field as expanded. "Partial" is really an indicator for the health of a logical volume and it makes sense to extend this include other health indicators as well, specifically: 'm'ismatches: Indicates that there are discrepancies in a RAID LV. This character is shown after a scrubbing operation has detected that portions of the RAID are not coherent. 'r'efresh : Indicates that a device in a RAID array has suffered a failure and the kernel regards it as failed - even though LVM can read the device label and considers the device to be ok. The LV should be 'r'efreshed to notify the kernel that the device is now available, or the device should be 'r'eplaced if it is suspected of failing.
2013-04-12 00:33:59 +04:00
static uint64_t _mismatches(const struct logical_volume *lv) {
uint64_t cnt;
if (!lv_raid_mismatch_count(lv, &cnt))
return 0;
return cnt;
}
static char *_sync_action(const struct logical_volume *lv) {
char *action;
if (!lv_raid_sync_action(lv, &action))
return 0;
return action;
}
RAID: Add writemostly/writebehind support for RAID1 'lvchange' is used to alter a RAID 1 logical volume's write-mostly and write-behind characteristics. The '--writemostly' parameter takes a PV as an argument with an optional trailing character to specify whether to set ('y'), unset ('n'), or toggle ('t') the value. If no trailing character is given, it will set the flag. Synopsis: lvchange [--writemostly <PV>:{t|y|n}] [--writebehind <count>] vg/lv Example: lvchange --writemostly /dev/sdb1:y --writebehind 512 vg/raid1_lv The last character in the 'lv_attr' field is used to show whether a device has the WriteMostly flag set. It is signified with a 'w'. If the device has failed, the 'p'artial flag has priority. Example ("nosync" raid1 with mismatch_cnt and writemostly): [~]# lvs -a --segment vg LV VG Attr #Str Type SSize raid1 vg Rwi---r-m 2 raid1 500.00m [raid1_rimage_0] vg Iwi---r-- 1 linear 500.00m [raid1_rimage_1] vg Iwi---r-w 1 linear 500.00m [raid1_rmeta_0] vg ewi---r-- 1 linear 4.00m [raid1_rmeta_1] vg ewi---r-- 1 linear 4.00m Example (raid1 with mismatch_cnt, writemostly - but failed drive): [~]# lvs -a --segment vg LV VG Attr #Str Type SSize raid1 vg rwi---r-p 2 raid1 500.00m [raid1_rimage_0] vg Iwi---r-- 1 linear 500.00m [raid1_rimage_1] vg Iwi---r-p 1 linear 500.00m [raid1_rmeta_0] vg ewi---r-- 1 linear 4.00m [raid1_rmeta_1] vg ewi---r-p 1 linear 4.00m A new reportable field has been added for writebehind as well. If write-behind has not been set or the LV is not RAID1, the field will be blank. Example (writebehind is set): [~]# lvs -a -o name,attr,writebehind vg LV Attr WBehind lv rwi-a-r-- 512 [lv_rimage_0] iwi-aor-w [lv_rimage_1] iwi-aor-- [lv_rmeta_0] ewi-aor-- [lv_rmeta_1] ewi-aor-- Example (writebehind is not set): [~]# lvs -a -o name,attr,writebehind vg LV Attr WBehind lv rwi-a-r-- [lv_rimage_0] iwi-aor-w [lv_rimage_1] iwi-aor-- [lv_rmeta_0] ewi-aor-- [lv_rmeta_1] ewi-aor--
2013-04-15 22:59:46 +04:00
static uint32_t _writebehind(const struct logical_volume *lv) {
return first_seg(lv)->writebehind;
}
Add getters for copy_percent and snap_percent to the lvm2app API.
2010-12-15 02:20:58 +03:00
static percent_t _snap_percent(const struct logical_volume *lv) {
Return PERCENT_INVALID for error case If the percent value could not be determined return PERCENT_INVALID. Indent function with tabs.
2011-01-05 15:33:51 +03:00
percent_t perc;
report: call snapshot percent with cow only Ensure lv_snapshot_percent is used only with snapshot LVs.
2012-10-08 14:06:30 +04:00
if (!lv_is_cow(lv) || !lv_snapshot_percent(lv, &perc))
Return PERCENT_INVALID for error case If the percent value could not be determined return PERCENT_INVALID. Indent function with tabs.
2011-01-05 15:33:51 +03:00
perc = PERCENT_INVALID;
report: call snapshot percent with cow only Ensure lv_snapshot_percent is used only with snapshot LVs.
2012-10-08 14:06:30 +04:00
Return PERCENT_INVALID for error case If the percent value could not be determined return PERCENT_INVALID. Indent function with tabs.
2011-01-05 15:33:51 +03:00
return perc;
Add getters for copy_percent and snap_percent to the lvm2app API.
2010-12-15 02:20:58 +03:00
}
Thin add new display field for lvs New field Data% is able to display info about thin_pool, thin, snapshot and has generic meaning here. Simple Time/Host field are here to display host and time creation.
2012-01-19 19:34:32 +04:00
static percent_t _data_percent(const struct logical_volume *lv)
{
percent_t perc;
lvm2api: fix data percent reporting for thin, snap Use same logic for lvm2api as we use lvs reporting. data_percent is meant to be superset for snap_percent.
2012-10-05 11:56:50 +04:00
if (lv_is_cow(lv))
return _snap_percent(lv);
if (lv_is_thin_volume(lv))
return lv_thin_percent(lv, 0, &perc) ? perc : PERCENT_INVALID;
Thin add new display field for lvs New field Data% is able to display info about thin_pool, thin, snapshot and has generic meaning here. Simple Time/Host field are here to display host and time creation.
2012-01-19 19:34:32 +04:00
return lv_thin_pool_percent(lv, 0, &perc) ? perc : PERCENT_INVALID;
}
static percent_t _metadata_percent(const struct logical_volume *lv)
{
percent_t perc;
return lv_thin_pool_percent(lv, 1, &perc) ? perc : PERCENT_INVALID;
}
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
/* PV */
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_STR_PROPERTY_FN(pv_fmt, pv_fmt_dup(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_fmt_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_STR_PROPERTY_FN(pv_uuid, pv_uuid_dup(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_uuid_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(dev_size, SECTOR_SIZE * pv_dev_size(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _dev_size_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_STR_PROPERTY_FN(pv_name, pv_name_dup(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_name_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_mda_free, SECTOR_SIZE * pv_mda_free(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_mda_free_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_mda_size, SECTOR_SIZE * pv_mda_size(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_mda_size_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pe_start, SECTOR_SIZE * pv->pe_start)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pe_start_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_size, SECTOR_SIZE * pv_size_field(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_size_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_free, SECTOR_SIZE * pv_free(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_free_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_used, SECTOR_SIZE * pv_used(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_used_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_STR_PROPERTY_FN(pv_attr, pv_attr_dup(pv->vg->vgmem, pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_attr_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_pe_count, pv->pe_count)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_pe_count_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_pe_alloc_count, pv->pe_alloc_count)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_pe_alloc_count_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_STR_PROPERTY_FN(pv_tags, pv_tags_dup(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_tags_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_mda_count, pv_mda_count(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_mda_count_set _not_implemented_set
Add pv 'get' functions for all pv properties. Add 'get' functions for all pv properties. Multiply by SECTOR_SIZE for pv properties pv_mda_free, pv_mda_size, pe_start, pv_size, pv_free, pv_used.
2010-09-30 18:09:33 +04:00
GET_PV_NUM_PROPERTY_FN(pv_mda_used_count, pv_mda_used_count(pv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_mda_used_count_set _not_implemented_set
report: add reporting fields for Embedding Area start and size There are new reporting fields for Embedding Area: ea_start and ea_size. An example of 1m Embedding Area and relevant reporting fields: raw/~ # pvs -o pv_name,pe_start,ea_start,ea_size PV 1st PE EA start EA size /dev/sda 2.00m 1.00m 1.00m
2013-02-16 18:10:47 +04:00
GET_PV_NUM_PROPERTY_FN(ea_start, SECTOR_SIZE * pv->ea_start)
#define _ea_start_set _not_implemented_set
GET_PV_NUM_PROPERTY_FN(ea_size, SECTOR_SIZE * pv->ea_size)
#define _ea_size_set _not_implemented_set
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
/* LV */
Add some lv 'get' functions that require no refactoring. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:11:20 +04:00
GET_LV_STR_PROPERTY_FN(lv_uuid, lv_uuid_dup(lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_uuid_set _not_implemented_set
Refactor and add code for (lv) 'lv_name' get function.
2010-10-21 18:49:10 +04:00
GET_LV_STR_PROPERTY_FN(lv_name, lv_name_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_name_set _not_implemented_set
Refactor and add code for (lv) 'lv_path' get function.
2010-10-12 20:11:34 +04:00
GET_LV_STR_PROPERTY_FN(lv_path, lv_path_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_path_set _not_implemented_set
Add some lv 'get' functions that require no refactoring. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:11:20 +04:00
GET_LV_STR_PROPERTY_FN(lv_attr, lv_attr_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_attr_set _not_implemented_set
Add some lv 'get' functions that require no refactoring. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:11:20 +04:00
GET_LV_NUM_PROPERTY_FN(lv_major, lv->major)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_major_set _not_implemented_set
Add some lv 'get' functions that require no refactoring. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:11:20 +04:00
GET_LV_NUM_PROPERTY_FN(lv_minor, lv->minor)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_minor_set _not_implemented_set
Add lv_read_ahead and lv_kernel_read_ahead 'get' functions.
2010-10-21 18:49:31 +04:00
GET_LV_NUM_PROPERTY_FN(lv_read_ahead, lv->read_ahead * SECTOR_SIZE)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_read_ahead_set _not_implemented_set
Refactor and add code for (lv) 'lv_kernel_{major|minor}' get functions. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:12:33 +04:00
GET_LV_NUM_PROPERTY_FN(lv_kernel_major, lv_kernel_major(lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_kernel_major_set _not_implemented_set
Refactor and add code for (lv) 'lv_kernel_{major|minor}' get functions. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:12:33 +04:00
GET_LV_NUM_PROPERTY_FN(lv_kernel_minor, lv_kernel_minor(lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_kernel_minor_set _not_implemented_set
Add lv_read_ahead and lv_kernel_read_ahead 'get' functions.
2010-10-21 18:49:31 +04:00
GET_LV_NUM_PROPERTY_FN(lv_kernel_read_ahead, lv_kernel_read_ahead(lv) * SECTOR_SIZE)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_kernel_read_ahead_set _not_implemented_set
Add some lv 'get' functions that require no refactoring. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:11:20 +04:00
GET_LV_NUM_PROPERTY_FN(lv_size, lv->size * SECTOR_SIZE)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_size_set _not_implemented_set
Add some lv 'get' functions that require no refactoring. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:11:20 +04:00
GET_LV_NUM_PROPERTY_FN(seg_count, dm_list_size(&lv->segments))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _seg_count_set _not_implemented_set
Refactor and add code for (lv) 'lv_origin' get function.
2010-10-21 18:49:20 +04:00
GET_LV_STR_PROPERTY_FN(origin, lv_origin_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _origin_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LV_NUM_PROPERTY_FN(origin_size, (SECTOR_SIZE * lv_origin_size(lv)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _origin_size_set _not_implemented_set
Add getters for copy_percent and snap_percent to the lvm2app API.
2010-12-15 02:20:58 +03:00
GET_LV_NUM_PROPERTY_FN(snap_percent, _snap_percent(lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _snap_percent_set _not_implemented_set
Add getters for copy_percent and snap_percent to the lvm2app API.
2010-12-15 02:20:58 +03:00
GET_LV_NUM_PROPERTY_FN(copy_percent, _copy_percent(lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _copy_percent_set _not_implemented_set
RAID: Make RAID 4/5/6 display sync status under heading s/Copy%/Cpy%Sync The heading 'Copy%' is specific to PVMOVE volumes, but can be generalized to apply to LVM mirrors also. It is a bit awkward to use 'Copy%' for RAID 4/5/6, however - 'Sync%' would be more appropriate. This is why RAID 4/5/6 have not displayed their sync status by any means available to 'lvs' yet. Example (old): [root@hayes-02 lvm2]# lvs vg LV VG Attr LSize Pool Origin Data% Move Log Cpy%Sy Convert lv vg -wi-a---- 1.00g raid1 vg rwi-a-r-- 1.00g 100.00 raid4 vg rwi-a-r-- 1.01g raid5 vg rwi-a-r-- 1.01g raid6 vg rwi-a-r-- 1.01g This patch changes the heading to 'Cpy%Sync' and allows RAID 4/5/6 to print their sync percent in this field. Example (new): [root@hayes-02 lvm2]# lvs vg LV VG Attr LSize Pool Origin Data% Move Log Cpy%Sync Convert lv vg -wi-a---- 1.00g raid1 vg rwi-a-r-- 1.00g 100.00 raid4 vg rwi-a-r-- 1.01g 100.00 raid5 vg rwi-a-r-- 1.01g 100.00 raid6 vg rwi-a-r-- 1.01g 100.00
2012-10-24 06:19:27 +04:00
GET_LV_NUM_PROPERTY_FN(sync_percent, _copy_percent(lv))
#define _sync_percent_set _not_implemented_set
RAID: Add scrubbing support for RAID LVs New options to 'lvchange' allow users to scrub their RAID LVs. Synopsis: lvchange --syncaction {check|repair} vg/raid_lv RAID scrubbing is the process of reading all the data and parity blocks in an array and checking to see whether they are coherent. 'lvchange' can now initaite the two scrubbing operations: "check" and "repair". "check" will go over the array and recored the number of discrepancies but not repair them. "repair" will correct the discrepancies as it finds them. 'lvchange --syncaction repair vg/raid_lv' is not to be confused with 'lvconvert --repair vg/raid_lv'. The former initiates a background synchronization operation on the array, while the latter is designed to repair/replace failed devices in a mirror or RAID logical volume. Additional reporting has been added for 'lvs' to support the new operations. Two new printable fields (which are not printed by default) have been added: "syncaction" and "mismatches". These can be accessed using the '-o' option to 'lvs', like: lvs -o +syncaction,mismatches vg/lv "syncaction" will print the current synchronization operation that the RAID volume is performing. It can be one of the following: - idle: All sync operations complete (doing nothing) - resync: Initializing an array or recovering after a machine failure - recover: Replacing a device in the array - check: Looking for array inconsistencies - repair: Looking for and repairing inconsistencies The "mismatches" field with print the number of descrepancies found during a check or repair operation. The 'Cpy%Sync' field already available to 'lvs' will print the progress of any of the above syncactions, including check and repair. Finally, the lv_attr field has changed to accomadate the scrubbing operations as well. The role of the 'p'artial character in the lv_attr report field as expanded. "Partial" is really an indicator for the health of a logical volume and it makes sense to extend this include other health indicators as well, specifically: 'm'ismatches: Indicates that there are discrepancies in a RAID LV. This character is shown after a scrubbing operation has detected that portions of the RAID are not coherent. 'r'efresh : Indicates that a device in a RAID array has suffered a failure and the kernel regards it as failed - even though LVM can read the device label and considers the device to be ok. The LV should be 'r'efreshed to notify the kernel that the device is now available, or the device should be 'r'eplaced if it is suspected of failing.
2013-04-12 00:33:59 +04:00
GET_LV_NUM_PROPERTY_FN(mismatches, _mismatches(lv))
#define _mismatches_set _not_implemented_set
RAID: Add writemostly/writebehind support for RAID1 'lvchange' is used to alter a RAID 1 logical volume's write-mostly and write-behind characteristics. The '--writemostly' parameter takes a PV as an argument with an optional trailing character to specify whether to set ('y'), unset ('n'), or toggle ('t') the value. If no trailing character is given, it will set the flag. Synopsis: lvchange [--writemostly <PV>:{t|y|n}] [--writebehind <count>] vg/lv Example: lvchange --writemostly /dev/sdb1:y --writebehind 512 vg/raid1_lv The last character in the 'lv_attr' field is used to show whether a device has the WriteMostly flag set. It is signified with a 'w'. If the device has failed, the 'p'artial flag has priority. Example ("nosync" raid1 with mismatch_cnt and writemostly): [~]# lvs -a --segment vg LV VG Attr #Str Type SSize raid1 vg Rwi---r-m 2 raid1 500.00m [raid1_rimage_0] vg Iwi---r-- 1 linear 500.00m [raid1_rimage_1] vg Iwi---r-w 1 linear 500.00m [raid1_rmeta_0] vg ewi---r-- 1 linear 4.00m [raid1_rmeta_1] vg ewi---r-- 1 linear 4.00m Example (raid1 with mismatch_cnt, writemostly - but failed drive): [~]# lvs -a --segment vg LV VG Attr #Str Type SSize raid1 vg rwi---r-p 2 raid1 500.00m [raid1_rimage_0] vg Iwi---r-- 1 linear 500.00m [raid1_rimage_1] vg Iwi---r-p 1 linear 500.00m [raid1_rmeta_0] vg ewi---r-- 1 linear 4.00m [raid1_rmeta_1] vg ewi---r-p 1 linear 4.00m A new reportable field has been added for writebehind as well. If write-behind has not been set or the LV is not RAID1, the field will be blank. Example (writebehind is set): [~]# lvs -a -o name,attr,writebehind vg LV Attr WBehind lv rwi-a-r-- 512 [lv_rimage_0] iwi-aor-w [lv_rimage_1] iwi-aor-- [lv_rmeta_0] ewi-aor-- [lv_rmeta_1] ewi-aor-- Example (writebehind is not set): [~]# lvs -a -o name,attr,writebehind vg LV Attr WBehind lv rwi-a-r-- [lv_rimage_0] iwi-aor-w [lv_rimage_1] iwi-aor-- [lv_rmeta_0] ewi-aor-- [lv_rmeta_1] ewi-aor--
2013-04-15 22:59:46 +04:00
GET_LV_NUM_PROPERTY_FN(writebehind, _writebehind(lv))
#define _writebehind_set _not_implemented_set
RAID: Add scrubbing support for RAID LVs New options to 'lvchange' allow users to scrub their RAID LVs. Synopsis: lvchange --syncaction {check|repair} vg/raid_lv RAID scrubbing is the process of reading all the data and parity blocks in an array and checking to see whether they are coherent. 'lvchange' can now initaite the two scrubbing operations: "check" and "repair". "check" will go over the array and recored the number of discrepancies but not repair them. "repair" will correct the discrepancies as it finds them. 'lvchange --syncaction repair vg/raid_lv' is not to be confused with 'lvconvert --repair vg/raid_lv'. The former initiates a background synchronization operation on the array, while the latter is designed to repair/replace failed devices in a mirror or RAID logical volume. Additional reporting has been added for 'lvs' to support the new operations. Two new printable fields (which are not printed by default) have been added: "syncaction" and "mismatches". These can be accessed using the '-o' option to 'lvs', like: lvs -o +syncaction,mismatches vg/lv "syncaction" will print the current synchronization operation that the RAID volume is performing. It can be one of the following: - idle: All sync operations complete (doing nothing) - resync: Initializing an array or recovering after a machine failure - recover: Replacing a device in the array - check: Looking for array inconsistencies - repair: Looking for and repairing inconsistencies The "mismatches" field with print the number of descrepancies found during a check or repair operation. The 'Cpy%Sync' field already available to 'lvs' will print the progress of any of the above syncactions, including check and repair. Finally, the lv_attr field has changed to accomadate the scrubbing operations as well. The role of the 'p'artial character in the lv_attr report field as expanded. "Partial" is really an indicator for the health of a logical volume and it makes sense to extend this include other health indicators as well, specifically: 'm'ismatches: Indicates that there are discrepancies in a RAID LV. This character is shown after a scrubbing operation has detected that portions of the RAID are not coherent. 'r'efresh : Indicates that a device in a RAID array has suffered a failure and the kernel regards it as failed - even though LVM can read the device label and considers the device to be ok. The LV should be 'r'efreshed to notify the kernel that the device is now available, or the device should be 'r'eplaced if it is suspected of failing.
2013-04-12 00:33:59 +04:00
GET_LV_STR_PROPERTY_FN(syncaction, _sync_action(lv))
#define _syncaction_set _not_implemented_set
Refactor and add code for (lv) 'move_pv' get function. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:12:02 +04:00
GET_LV_STR_PROPERTY_FN(move_pv, lv_move_pv_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _move_pv_set _not_implemented_set
Refactor and add code for (lv) 'convert_lv' get function. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:12:18 +04:00
GET_LV_STR_PROPERTY_FN(convert_lv, lv_convert_lv_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _convert_lv_set _not_implemented_set
Add some lv 'get' functions that require no refactoring. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:11:20 +04:00
GET_LV_STR_PROPERTY_FN(lv_tags, lv_tags_dup(lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_tags_set _not_implemented_set
Refactor and add code for (lv) 'mirror_log' get function. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-By: Petr Rockai <prockai@redhat.com>
2010-10-12 20:12:50 +04:00
GET_LV_STR_PROPERTY_FN(mirror_log, lv_mirror_log_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _mirror_log_set _not_implemented_set
Refactor and add code for (lv) 'modules' get function.
2010-10-12 20:13:06 +04:00
GET_LV_STR_PROPERTY_FN(modules, lv_modules_dup(lv->vg->vgmem, lv))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _modules_set _not_implemented_set
Thin add new display field for lvs New field Data% is able to display info about thin_pool, thin, snapshot and has generic meaning here. Simple Time/Host field are here to display host and time creation.
2012-01-19 19:34:32 +04:00
GET_LV_STR_PROPERTY_FN(data_lv, lv_data_lv_dup(lv->vg->vgmem, lv))
#define _data_lv_set _not_implemented_set
GET_LV_STR_PROPERTY_FN(metadata_lv, lv_metadata_lv_dup(lv->vg->vgmem, lv))
#define _metadata_lv_set _not_implemented_set
GET_LV_STR_PROPERTY_FN(pool_lv, lv_pool_lv_dup(lv->vg->vgmem, lv))
#define _pool_lv_set _not_implemented_set
GET_LV_NUM_PROPERTY_FN(data_percent, _data_percent(lv))
#define _data_percent_set _not_implemented_set
GET_LV_NUM_PROPERTY_FN(metadata_percent, _metadata_percent(lv))
#define _metadata_percent_set _not_implemented_set
GET_LV_NUM_PROPERTY_FN(lv_metadata_size, lv_metadata_size(lv) * SECTOR_SIZE)
#define _lv_metadata_size_set _not_implemented_set
GET_LV_STR_PROPERTY_FN(lv_time, lv_time_dup(lv->vg->vgmem, lv))
#define _lv_time_set _not_implemented_set
GET_LV_STR_PROPERTY_FN(lv_host, lv_host_dup(lv->vg->vgmem, lv))
#define _lv_host_set _not_implemented_set
report: show active state of LV For non clustered VG - show "active"/"" For clustered VG its more complex: "local exclusive" "remote exclusive" "locally" "remotely"
2013-04-25 14:12:05 +04:00
GET_LV_STR_PROPERTY_FN(lv_active, lv_active_dup(lv->vg->vgmem, lv))
#define _lv_active_set _not_implemented_set
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
/* VG */
Add 'get' functions for vg fields. Add 'get' functions based on generic macros for VG, PV, and LV. Add 'get' functions for vg string fields, vg_name, vg_fmt, vg_sysid, vg_uuid, vg_attr, and vg_tags, and all numeric fields.
2010-09-30 18:08:58 +04:00
GET_VG_STR_PROPERTY_FN(vg_fmt, vg_fmt_dup(vg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_fmt_set _not_implemented_set
Add 'get' functions for vg fields. Add 'get' functions based on generic macros for VG, PV, and LV. Add 'get' functions for vg string fields, vg_name, vg_fmt, vg_sysid, vg_uuid, vg_attr, and vg_tags, and all numeric fields.
2010-09-30 18:08:58 +04:00
GET_VG_STR_PROPERTY_FN(vg_uuid, vg_uuid_dup(vg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_uuid_set _not_implemented_set
Add 'get' functions for vg fields. Add 'get' functions based on generic macros for VG, PV, and LV. Add 'get' functions for vg string fields, vg_name, vg_fmt, vg_sysid, vg_uuid, vg_attr, and vg_tags, and all numeric fields.
2010-09-30 18:08:58 +04:00
GET_VG_STR_PROPERTY_FN(vg_name, vg_name_dup(vg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_name_set _not_implemented_set
Add 'get' functions for vg fields. Add 'get' functions based on generic macros for VG, PV, and LV. Add 'get' functions for vg string fields, vg_name, vg_fmt, vg_sysid, vg_uuid, vg_attr, and vg_tags, and all numeric fields.
2010-09-30 18:08:58 +04:00
GET_VG_STR_PROPERTY_FN(vg_attr, vg_attr_dup(vg->vgmem, vg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_attr_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_size, (SECTOR_SIZE * vg_size(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_size_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_free, (SECTOR_SIZE * vg_free(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_free_set _not_implemented_set
Add 'get' functions for vg fields. Add 'get' functions based on generic macros for VG, PV, and LV. Add 'get' functions for vg string fields, vg_name, vg_fmt, vg_sysid, vg_uuid, vg_attr, and vg_tags, and all numeric fields.
2010-09-30 18:08:58 +04:00
GET_VG_STR_PROPERTY_FN(vg_sysid, vg_system_id_dup(vg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_sysid_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_VG_NUM_PROPERTY_FN(vg_extent_size, (SECTOR_SIZE * vg->extent_size))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_extent_size_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_extent_count, vg->extent_count)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_extent_count_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_free_count, vg->free_count)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_free_count_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(max_lv, vg->max_lv)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _max_lv_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(max_pv, vg->max_pv)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _max_pv_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(pv_count, vg->pv_count)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pv_count_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(lv_count, (vg_visible_lvs(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _lv_count_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(snap_count, (snapshot_count(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _snap_count_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_seqno, vg->seqno)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_seqno_set _not_implemented_set
Add 'get' functions for vg fields. Add 'get' functions based on generic macros for VG, PV, and LV. Add 'get' functions for vg string fields, vg_name, vg_fmt, vg_sysid, vg_uuid, vg_attr, and vg_tags, and all numeric fields.
2010-09-30 18:08:58 +04:00
GET_VG_STR_PROPERTY_FN(vg_tags, vg_tags_dup(vg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_tags_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_mda_count, (vg_mda_count(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_mda_count_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_mda_used_count, (vg_mda_used_count(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_mda_used_count_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_mda_free, (SECTOR_SIZE * vg_mda_free(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_mda_free_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_mda_size, (SECTOR_SIZE * vg_mda_size(vg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _vg_mda_size_set _not_implemented_set
Make generic GET_*_PROPERTY_FN macros and define secondary macro for vg, pv, lv. Will need similar macros for VG, PV and LV, so define a generic one, and just pass in the struct name and variable name for the specific macro.
2010-09-30 18:08:46 +04:00
GET_VG_NUM_PROPERTY_FN(vg_mda_copies, (vg_mda_copies(vg)))
Add generic infrastructure to internal library to 'set' a property. Similar to 'get' property internal functions. Add specific 'set' function for vg_mda_copies. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 22:15:10 +03:00
SET_VG_NUM_PROPERTY_FN(vg_mda_copies, vg_set_mda_copies)
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
/* LVSEG */
Fix reading of released memory lvseg_segtype_dup used memory pool vg memory pool for strind duplication. However this one gets released before reporting happens so the command like: pvs -o segtype prints data from already released memory pool. Thanks to the fact there is not much allocation happing after the VG is released, the memory stays unmodified and correct result is printed. Fix adds support for mempool passed parameter (like other similar query commands) and uses dm_report memory pool for string duplication.
2011-03-05 15:14:00 +03:00
GET_LVSEG_STR_PROPERTY_FN(segtype, lvseg_segtype_dup(lvseg->lv->vg->vgmem, lvseg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _segtype_set _not_implemented_set
Add the macro and specific 'get' functions for lvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:08:14 +03:00
GET_LVSEG_NUM_PROPERTY_FN(stripes, lvseg->area_count)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _stripes_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LVSEG_NUM_PROPERTY_FN(stripesize, (SECTOR_SIZE * lvseg->stripe_size))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _stripesize_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LVSEG_NUM_PROPERTY_FN(stripe_size, (SECTOR_SIZE * lvseg->stripe_size))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _stripe_size_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LVSEG_NUM_PROPERTY_FN(regionsize, (SECTOR_SIZE * lvseg->region_size))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _regionsize_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LVSEG_NUM_PROPERTY_FN(region_size, (SECTOR_SIZE * lvseg->region_size))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _region_size_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LVSEG_NUM_PROPERTY_FN(chunksize, (SECTOR_SIZE * lvseg_chunksize(lvseg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _chunksize_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LVSEG_NUM_PROPERTY_FN(chunk_size, (SECTOR_SIZE * lvseg_chunksize(lvseg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _chunk_size_set _not_implemented_set
Thin add new display field for lvs New field Data% is able to display info about thin_pool, thin, snapshot and has generic meaning here. Simple Time/Host field are here to display host and time creation.
2012-01-19 19:34:32 +04:00
GET_LVSEG_NUM_PROPERTY_FN(thin_count, dm_list_size(&lvseg->lv->segs_using_this_lv))
#define _thin_count_set _not_implemented_set
GET_LVSEG_NUM_PROPERTY_FN(zero, lvseg->zero_new_blocks)
#define _zero_set _not_implemented_set
GET_LVSEG_NUM_PROPERTY_FN(transaction_id, lvseg->transaction_id)
#define _transaction_id_set _not_implemented_set
thin: fix property discard for lvm2api Discards property is string and may have these values: ignore, nopassdown, passdown
2012-11-27 14:02:49 +04:00
GET_LVSEG_STR_PROPERTY_FN(discards, lvseg_discards_dup(lvseg->lv->vg->vgmem, lvseg))
thin: use discards as plural rather than singular Global change from --discard to --discards, as that feels more natural.
2012-08-08 00:24:41 +04:00
#define _discards_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_LVSEG_NUM_PROPERTY_FN(seg_start, (SECTOR_SIZE * lvseg_start(lvseg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _seg_start_set _not_implemented_set
Add the macro and specific 'get' functions for lvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:08:14 +03:00
GET_LVSEG_NUM_PROPERTY_FN(seg_start_pe, lvseg->le)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _seg_start_pe_set _not_implemented_set
All 'size' values of lvm2app properties should be in bytes. Fix 'seg_size' to return bytes. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-25 17:39:02 +03:00
GET_LVSEG_NUM_PROPERTY_FN(seg_size, (SECTOR_SIZE * lvseg_size(lvseg)))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _seg_size_set _not_implemented_set
Add the macro and specific 'get' functions for lvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:08:14 +03:00
GET_LVSEG_STR_PROPERTY_FN(seg_tags, lvseg_tags_dup(lvseg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _seg_tags_set _not_implemented_set
This patchset refactors some reporting code and completes the remaining lvseg properties for lvm2app, 'devices' and 'seg_pe_ranges'. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2011-04-12 16:24:29 +04:00
GET_LVSEG_STR_PROPERTY_FN(seg_pe_ranges,
lvseg_seg_pe_ranges(lvseg->lv->vg->vgmem, lvseg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _seg_pe_ranges_set _not_implemented_set
This patchset refactors some reporting code and completes the remaining lvseg properties for lvm2app, 'devices' and 'seg_pe_ranges'. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2011-04-12 16:24:29 +04:00
GET_LVSEG_STR_PROPERTY_FN(devices, lvseg_devices(lvseg->lv->vg->vgmem, lvseg))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _devices_set _not_implemented_set
report: show dmeventd monitoring status Add new lvs segment field 'Monitor' showing 3 states: "monitored" - LV is monitored by dmeventd. "not monitored" - LV is currently not being monitored by dmeventd "" (empty) - LV does not support monitoring, or dmeventd support is not compiled in.
2013-04-25 14:07:57 +04:00
GET_LVSEG_STR_PROPERTY_FN(monitor, lvseg_monitor_dup(lvseg->lv->vg->vgmem, lvseg))
#define _monitor_set _not_implemented_set
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
/* PVSEG */
Add the macro and specific 'get' functions for pvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:11:27 +03:00
GET_PVSEG_NUM_PROPERTY_FN(pvseg_start, pvseg->pe)
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pvseg_start_set _not_implemented_set
lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent.
2012-11-29 13:29:03 +04:00
GET_PVSEG_NUM_PROPERTY_FN(pvseg_size, (SECTOR_SIZE * pvseg->len))
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
#define _pvseg_size_set _not_implemented_set
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
#define STR DM_REPORT_FIELD_TYPE_STRING
#define NUM DM_REPORT_FIELD_TYPE_NUMBER
Rename fields in lvm_property_type. Based on review comments, rename a few fields in lvm_property_type. In particular, change 'is_writeable' to 'is_settable', which is more intuitive to the intent of the bitfield (a 'set' function exists for this field/property). Also, remove the char array for 'id' - unnecessary as we can just use the string passed in to do the strcmp. Finally rename the union members from n_val to 'integer' and 's_val' to 'string'.
2010-10-21 18:49:43 +04:00
#define FIELD(type, strct, sorttype, head, field, width, fn, id, desc, settable) \
Add 'is_integer' flag into internal lvm_property_type. Add 'is_integer' flag similar to 'is_string'. Suggested in review by Petr Rockai.
2010-10-25 18:08:32 +04:00
{ type, #id, settable, sorttype == STR, sorttype == NUM, { .integer = 0 }, _ ## id ## _get, _ ## id ## _set },
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
struct lvm_property_type _properties[] = {
#include "columns.h"
Add 'is_integer' flag into internal lvm_property_type. Add 'is_integer' flag similar to 'is_string'. Suggested in review by Petr Rockai.
2010-10-25 18:08:32 +04:00
{ 0, "", 0, 0, 0, { .integer = 0 }, _not_implemented_get, _not_implemented_set },
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
};
#undef STR
#undef NUM
#undef FIELD
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
static int _get_property(const void *obj, struct lvm_property_type *prop,
Use unsigned type for bitmask Using report_type_t for bitmask is not correct, since we have not defined types for all bit combinations - so switching to unsigned type, since values of report_type_t enum are unsigned.
2012-02-27 15:45:05 +04:00
unsigned type)
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
{
struct lvm_property_type *p;
p = _properties;
while (p->id[0]) {
if (!strcmp(p->id, prop->id))
break;
p++;
}
if (!p->id[0]) {
log_errno(EINVAL, "Invalid property name %s", prop->id);
return 0;
}
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
if (!(p->type & type)) {
log_errno(EINVAL, "Property name %s does not match type %d",
prop->id, p->type);
return 0;
}
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
*prop = *p;
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
if (!p->get(obj, prop)) {
Define GET_NUM_PROPERTY_FN macro to simplify numeric property 'get' functions.
2010-08-20 16:44:58 +04:00
return 0;
}
return 1;
}
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
Add generic infrastructure to internal library to 'set' a property. Similar to 'get' property internal functions. Add specific 'set' function for vg_mda_copies. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 22:15:10 +03:00
static int _set_property(void *obj, struct lvm_property_type *prop,
Use unsigned type for bitmask Using report_type_t for bitmask is not correct, since we have not defined types for all bit combinations - so switching to unsigned type, since values of report_type_t enum are unsigned.
2012-02-27 15:45:05 +04:00
unsigned type)
Add generic infrastructure to internal library to 'set' a property. Similar to 'get' property internal functions. Add specific 'set' function for vg_mda_copies. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 22:15:10 +03:00
{
struct lvm_property_type *p;
p = _properties;
while (p->id[0]) {
if (!strcmp(p->id, prop->id))
break;
p++;
}
if (!p->id[0]) {
log_errno(EINVAL, "Invalid property name %s", prop->id);
return 0;
}
if (!p->is_settable) {
log_errno(EINVAL, "Unable to set read-only property %s",
prop->id);
return 0;
}
if (!(p->type & type)) {
log_errno(EINVAL, "Property name %s does not match type %d",
prop->id, p->type);
return 0;
}
if (p->is_string)
p->value.string = prop->value.string;
else
p->value.integer = prop->value.integer;
if (!p->set(obj, p)) {
return 0;
}
return 1;
}
Add the macro and specific 'get' functions for lvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:08:14 +03:00
int lvseg_get_property(const struct lv_segment *lvseg,
struct lvm_property_type *prop)
{
return _get_property(lvseg, prop, SEGS);
}
Add lv_get_property() internal lvm function.
2010-10-21 22:51:16 +04:00
int lv_get_property(const struct logical_volume *lv,
struct lvm_property_type *prop)
{
return _get_property(lv, prop, LVS);
}
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
int vg_get_property(const struct volume_group *vg,
struct lvm_property_type *prop)
{
return _get_property(vg, prop, VGS);
}
Add the macro and specific 'get' functions for pvsegs. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 23:11:27 +03:00
int pvseg_get_property(const struct pv_segment *pvseg,
struct lvm_property_type *prop)
{
return _get_property(pvseg, prop, PVSEGS);
}
Add pv_get_property and create generic internal _get_property function. We need to use a similar function for pv and lv properties, so just make a generic _get_property() function that contains most of the required functionality. Also, add a check to ensure the field name matches the object passed in by re-using report_type_t enum. For pv properties, the report_type might be either PVS or LABEL. In addition, add 'const' to 'get' functions object parameter, but not 'set' functions. Add _not_implemented_set() and _not_implemented_get() functions.
2010-09-30 18:09:45 +04:00
int pv_get_property(const struct physical_volume *pv,
struct lvm_property_type *prop)
{
return _get_property(pv, prop, PVS | LABEL);
}
Add generic infrastructure to internal library to 'set' a property. Similar to 'get' property internal functions. Add specific 'set' function for vg_mda_copies. Signed-off-by: Dave Wysochanski <wysochanski@pobox.com> Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 22:15:10 +03:00
int lv_set_property(struct logical_volume *lv,
struct lvm_property_type *prop)
{
return _set_property(lv, prop, LVS);
}
int vg_set_property(struct volume_group *vg,
struct lvm_property_type *prop)
{
return _set_property(vg, prop, VGS);
}
int pv_set_property(struct physical_volume *pv,
struct lvm_property_type *prop)
{
return _set_property(pv, prop, PVS | LABEL);
}
Copy Permalink