shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity
e150931fc4
lvm2/lib/filters/filter-regex.c

256 lines
5.3 KiB
C
Raw Normal View History

o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
/*
Some whitespace tidy-ups.
2008-01-30 17:00:02 +03:00
* Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved.
Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.
2007-08-21 00:55:30 +04:00
* Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved.
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
*
Update copyright notices.
2004-03-30 23:35:44 +04:00
* This file is part of LVM2.
*
* This copyrighted material is made available to anyone wishing to use,
* modify, copy, or redistribute it subject to the terms and conditions
Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.
2007-08-21 00:55:30 +04:00
* of the GNU Lesser General Public License v.2.1.
Update copyright notices.
2004-03-30 23:35:44 +04:00
*
Fix inconsistent licence notices: executables are GPLv2; libraries LGPLv2.1.
2007-08-21 00:55:30 +04:00
* You should have received a copy of the GNU Lesser General Public License
Update copyright notices.
2004-03-30 23:35:44 +04:00
* along with this program; if not, write to the Free Software Foundation,
doc: change fsf address Hmm rpmlint suggest fsf is using a different address these days, so lets keep it up-to-date
2016-01-21 13:49:46 +03:00
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
*/
build: Don't generate symlinks in include/ dir As we start refactoring the code to break dependencies (see doc/refactoring.txt), I want us to use full paths in the includes (eg, #include "base/data-struct/list.h"). This makes it more obvious when we're breaking abstraction boundaries, eg, including a file in metadata/ from base/
2018-05-14 12:30:20 +03:00
#include "lib/misc/lib.h"
#include "lib/filters/filter.h"
device usage based on devices file The LVM devices file lists devices that lvm can use. The default file is /etc/lvm/devices/system.devices, and the lvmdevices(8) command is used to add or remove device entries. If the file does not exist, or if lvm.conf includes use_devicesfile=0, then lvm will not use a devices file. When the devices file is in use, the regex filter is not used, and the filter settings in lvm.conf or on the command line are ignored. LVM records devices in the devices file using hardware-specific IDs, such as the WWID, and attempts to use subsystem-specific IDs for virtual device types. These device IDs are also written in the VG metadata. When no hardware or virtual ID is available, lvm falls back using the unstable device name as the device ID. When devnames are used, lvm performs extra scanning to find devices if their devname changes, e.g. after reboot. When proper device IDs are used, an lvm command will not look at devices outside the devices file, but when devnames are used as a fallback, lvm will scan devices outside the devices file to locate PVs on renamed devices. A config setting search_for_devnames can be used to control the scanning for renamed devname entries. Related to the devices file, the new command option --devices <devnames> allows a list of devices to be specified for the command to use, overriding the devices file. The listed devices act as a sort of devices file in terms of limiting which devices lvm will see and use. Devices that are not listed will appear to be missing to the lvm command. Multiple devices files can be kept in /etc/lvm/devices, which allows lvm to be used with different sets of devices, e.g. system devices do not need to be exposed to a specific application, and the application can use lvm on its own set of devices that are not exposed to the system. The option --devicesfile <filename> is used to select the devices file to use with the command. Without the option set, the default system devices file is used. Setting --devicesfile "" causes lvm to not use a devices file. An existing, empty devices file means lvm will see no devices. The new command vgimportdevices adds PVs from a VG to the devices file and updates the VG metadata to include the device IDs. vgimportdevices -a will import all VGs into the system devices file. LVM commands run by dmeventd not use a devices file by default, and will look at all devices on the system. A devices file can be created for dmeventd (/etc/lvm/devices/dmeventd.devices) If this file exists, lvm commands run by dmeventd will use it. Internal implementaion: - device_ids_read - read the devices file . add struct dev_use (du) to cmd->use_devices for each devices file entry - dev_cache_scan - get /dev entries . add struct device (dev) to dev_cache for each device on the system - device_ids_match - match devices file entries to /dev entries . match each du on cmd->use_devices to a dev in dev_cache, using device ID . on match, set du->dev, dev->id, dev->flags MATCHED_USE_ID - label_scan - read lvm headers and metadata from devices . filters are applied, those that do not need data from the device . filter-deviceid skips devs without MATCHED_USE_ID, i.e. skips /dev entries that are not listed in the devices file . read lvm label from dev . filters are applied, those that use data from the device . read lvm metadata from dev . add info/vginfo structs for PVs/VGs (info is "lvmcache") - device_ids_find_renamed_devs - handle devices with unstable devname ID where devname changed . this step only needed when devs do not have proper device IDs, and their dev names change, e.g. after reboot sdb becomes sdc. . detect incorrect match because PVID in the devices file entry does not match the PVID found when the device was read above . undo incorrect match between du and dev above . search system devices for new location of PVID . update devices file with new devnames for PVIDs on renamed devices . label_scan the renamed devs - continue with command processing
2020-06-23 21:25:41 +03:00
#include "lib/commands/toolcontext.h"
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
struct rfilter {
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
struct dm_pool *mem;
dm_bitset_t accept;
Move regex functions into libdevmapper.
2007-04-27 22:52:05 +04:00
struct dm_regex *engine;
devices file: recommend removing filter When the devices file is enabled and the filter is set, recommand that the user remove the filter from lvm.conf since it's ignored.
2021-05-05 21:59:42 +03:00
unsigned config_filter:1;
unsigned config_global_filter:1;
unsigned warned_filter:1;
unsigned warned_global_filter:1;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
};
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
static int _extract_pattern(struct dm_pool *mem, const char *pat,
char **regex, dm_bitset_t accept, int ix)
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
{
char sep, *r, *ptr;
/*
* is this an accept or reject pattern
*/
switch (*pat) {
case 'a':
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
dm_bit_set(accept, ix);
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
break;
case 'r':
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
dm_bit_clear(accept, ix);
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
break;
default:
cleanup: log_info to log_error Switch to more appropriate logging level.
2016-10-31 20:03:06 +03:00
log_error("Pattern must begin with 'a' or 'r'.");
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
return 0;
}
pat++;
/*
spelling corrections
2004-03-30 18:36:50 +04:00
* get the separator
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
*/
switch (*pat) {
case '(':
sep = ')';
break;
case '[':
sep = ']';
break;
case '{':
sep = '}';
break;
default:
sep = *pat;
}
pat++;
/*
* copy the regex
*/
Use stack return macros throughout.
2008-01-30 16:19:47 +03:00
if (!(r = dm_pool_strdup(mem, pat)))
return_0;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
/*
* trim the trailing character, having checked it's sep.
*/
ptr = r + strlen(r) - 1;
if (*ptr != sep) {
cleanup: log_info to log_error Switch to more appropriate logging level.
2016-10-31 20:03:06 +03:00
log_error("Invalid separator at end of regex.");
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
return 0;
}
*ptr = '\0';
Default stripesize 64k & config file setting for it; Clear many compiler warnings (i386) & associated bugs - hopefully without introducing too many new bugs:-) (Same exercise required for other archs.) Default compilation has optimisation - or else use ./configure --enable-debug
2002-12-20 02:25:55 +03:00
regex[ix] = r;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
return 1;
}
Move the core of the lib/config/config.c functionality into libdevmapper, leaving behind the LVM-specific parts of the code (convenience wrappers that handle `struct device` and `struct cmd_context`, basically). A number of functions have been renamed (in addition to getting a dm_ prefix) -- namely, all of the config interface now has a dm_config_ prefix.
2011-08-30 18:55:15 +04:00
static int _build_matcher(struct rfilter *rf, const struct dm_config_value *val)
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
{
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
struct dm_pool *scratch;
Move the core of the lib/config/config.c functionality into libdevmapper, leaving behind the LVM-specific parts of the code (convenience wrappers that handle `struct device` and `struct cmd_context`, basically). A number of functions have been renamed (in addition to getting a dm_ prefix) -- namely, all of the config interface now has a dm_config_ prefix.
2011-08-30 18:55:15 +04:00
const struct dm_config_value *v;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
char **regex;
Default stripesize 64k & config file setting for it; Clear many compiler warnings (i386) & associated bugs - hopefully without introducing too many new bugs:-) (Same exercise required for other archs.) Default compilation has optimisation - or else use ./configure --enable-debug
2002-12-20 02:25:55 +03:00
unsigned count = 0;
int i, r = 0;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
Move regex functions into libdevmapper.
2007-04-27 22:52:05 +04:00
if (!(scratch = dm_pool_create("filter dm_regex", 1024)))
Add devices/preferred_names config regex list for displayed device names. Free a temporary dir string in fcntl_lock_file() after use. Fix a dm_pool_destroy() in matcher_create(). Introduce goto_bad macro.
2007-04-26 20:44:59 +04:00
return_0;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
/*
* count how many patterns we have.
*/
for (v = val; v; v = v->next) {
Move the core of the lib/config/config.c functionality into libdevmapper, leaving behind the LVM-specific parts of the code (convenience wrappers that handle `struct device` and `struct cmd_context`, basically). A number of functions have been renamed (in addition to getting a dm_ prefix) -- namely, all of the config interface now has a dm_config_ prefix.
2011-08-30 18:55:15 +04:00
if (v->type != DM_CFG_STRING) {
Show string with invalid pattern and start error message with capital letter.
2010-04-30 16:31:32 +04:00
log_error("Filter patterns must be enclosed in quotes.");
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
goto out;
}
count++;
}
Add check for allocation failure
2012-02-13 15:16:42 +04:00
/* Allocate space for them */
if (!(regex = dm_pool_alloc(scratch, sizeof(*regex) * count))) {
log_error("Failed to allocate regex.");
goto out;
}
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
Add check for allocation failure
2012-02-13 15:16:42 +04:00
/* Create the accept/reject bitset */
if (!(rf->accept = dm_bitset_create(rf->mem, count))) {
log_error("Failed to create bitset.");
goto out;
}
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
/*
* fill the array back to front because we
* want the opposite precedence to what
* the matcher gives.
*/
for (v = val, i = count - 1; v; v = v->next, i--)
Merge with text format branch. Lots of changes/very little testing so far => there'll be bugs! Use 'vgcreate -M text' to create a volume group with its metadata stored in text files. Text format metadata changes should be reasonably atomic, with a (basic) automatic recovery mechanism if the system crashes while a change is in progress. Add a metadata section to lvm.conf to specify multiple directories if you want (recommended) to keep multiple copies of the metadata (eg on different filesystems). e.g. metadata { dirs = ["/etc/lvm/metadata1","/usr/local/lvm/metadata2"] } Plenty of refinements still in the pipeline.
2002-04-24 22:20:51 +04:00
if (!_extract_pattern(scratch, v->v.str, regex, rf->accept, i)) {
Show string with invalid pattern and start error message with capital letter.
2010-04-30 16:31:32 +04:00
log_error("Invalid filter pattern \"%s\".", v->v.str);
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
goto out;
}
/*
* build the matcher.
*/
Const fixing Fixing some const warnings - with API change in: int vg_extend(struct volume_group *vg, int pv_count, const char *const *pv_names, Change is needed - as lvm2api expects const behaviour here. So vg_extend() is doing local strdup for unescaping. skip_dev_dir return const char* from const char* vg_name. Rest of the patch is cleanup of related warnings. Also using dm_report_filed_string() API change to simplify casting in _string_disp and _lvname_disp.
2011-02-18 17:47:28 +03:00
if (!(rf->engine = dm_regex_create(rf->mem, (const char * const*) regex,
Move regex functions into libdevmapper.
2007-04-27 22:52:05 +04:00
count)))
Fix error path if regex engine cannot be created in _build_matcher(). Fix only 'stack' printing with full function error exit.
2010-12-20 16:45:39 +03:00
goto_out;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
r = 1;
Merge with text format branch. Lots of changes/very little testing so far => there'll be bugs! Use 'vgcreate -M text' to create a volume group with its metadata stored in text files. Text format metadata changes should be reasonably atomic, with a (basic) automatic recovery mechanism if the system crashes while a change is in progress. Add a metadata section to lvm.conf to specify multiple directories if you want (recommended) to keep multiple copies of the metadata (eg on different filesystems). e.g. metadata { dirs = ["/etc/lvm/metadata1","/usr/local/lvm/metadata2"] } Plenty of refinements still in the pipeline.
2002-04-24 22:20:51 +04:00
out:
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
dm_pool_destroy(scratch);
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
return r;
}
add device hints to reduce scanning Save the list of PVs in /run/lvm/hints. These hints are used to reduce scanning in a number of commands to only the PVs on the system, or only the PVs in a requested VG (rather than all devices on the system.)
2018-12-07 23:35:22 +03:00
static int _accept_p(struct cmd_context *cmd, struct dev_filter *f, struct device *dev, const char *use_filter_name)
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
{
o if any pattern rejects a device, and there were no accepts then reject !
2001-11-12 20:06:33 +03:00
int m, first = 1, rejected = 0;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
struct rfilter *rf = (struct rfilter *) f->private;
report: select: refactor: move str_list to libdm The list of strings is used quite frequently and we'd like to reuse this simple structure for report selection support too. Make it part of libdevmapper for general reuse throughout the code. This also simplifies the LVM code a bit since we don't need to include and manage lvm-types.h anymore (the string list was the only structure defined there).
2014-05-29 11:41:03 +04:00
struct dm_str_list *sl;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
devices: support printing the filter that rejects a device Use of this new message function needs to be added to various commands to improve the output.
2020-07-20 20:48:36 +03:00
dev->filtered_flags &= ~DEV_FILTERED_REGEX;
device usage based on devices file The LVM devices file lists devices that lvm can use. The default file is /etc/lvm/devices/system.devices, and the lvmdevices(8) command is used to add or remove device entries. If the file does not exist, or if lvm.conf includes use_devicesfile=0, then lvm will not use a devices file. When the devices file is in use, the regex filter is not used, and the filter settings in lvm.conf or on the command line are ignored. LVM records devices in the devices file using hardware-specific IDs, such as the WWID, and attempts to use subsystem-specific IDs for virtual device types. These device IDs are also written in the VG metadata. When no hardware or virtual ID is available, lvm falls back using the unstable device name as the device ID. When devnames are used, lvm performs extra scanning to find devices if their devname changes, e.g. after reboot. When proper device IDs are used, an lvm command will not look at devices outside the devices file, but when devnames are used as a fallback, lvm will scan devices outside the devices file to locate PVs on renamed devices. A config setting search_for_devnames can be used to control the scanning for renamed devname entries. Related to the devices file, the new command option --devices <devnames> allows a list of devices to be specified for the command to use, overriding the devices file. The listed devices act as a sort of devices file in terms of limiting which devices lvm will see and use. Devices that are not listed will appear to be missing to the lvm command. Multiple devices files can be kept in /etc/lvm/devices, which allows lvm to be used with different sets of devices, e.g. system devices do not need to be exposed to a specific application, and the application can use lvm on its own set of devices that are not exposed to the system. The option --devicesfile <filename> is used to select the devices file to use with the command. Without the option set, the default system devices file is used. Setting --devicesfile "" causes lvm to not use a devices file. An existing, empty devices file means lvm will see no devices. The new command vgimportdevices adds PVs from a VG to the devices file and updates the VG metadata to include the device IDs. vgimportdevices -a will import all VGs into the system devices file. LVM commands run by dmeventd not use a devices file by default, and will look at all devices on the system. A devices file can be created for dmeventd (/etc/lvm/devices/dmeventd.devices) If this file exists, lvm commands run by dmeventd will use it. Internal implementaion: - device_ids_read - read the devices file . add struct dev_use (du) to cmd->use_devices for each devices file entry - dev_cache_scan - get /dev entries . add struct device (dev) to dev_cache for each device on the system - device_ids_match - match devices file entries to /dev entries . match each du on cmd->use_devices to a dev in dev_cache, using device ID . on match, set du->dev, dev->id, dev->flags MATCHED_USE_ID - label_scan - read lvm headers and metadata from devices . filters are applied, those that do not need data from the device . filter-deviceid skips devs without MATCHED_USE_ID, i.e. skips /dev entries that are not listed in the devices file . read lvm label from dev . filters are applied, those that use data from the device . read lvm metadata from dev . add info/vginfo structs for PVs/VGs (info is "lvmcache") - device_ids_find_renamed_devs - handle devices with unstable devname ID where devname changed . this step only needed when devs do not have proper device IDs, and their dev names change, e.g. after reboot sdb becomes sdc. . detect incorrect match because PVID in the devices file entry does not match the PVID found when the device was read above . undo incorrect match between du and dev above . search system devices for new location of PVID . update devices file with new devnames for PVIDs on renamed devices . label_scan the renamed devs - continue with command processing
2020-06-23 21:25:41 +03:00
if (cmd->enable_devices_list)
return 1;
vgchange autoactivation: skip regex filter containing symlinks "vgchange -aay --autoactivation event" is called by our udev rule. When the udev rule runs, symlinks for devices may not all be created yet. If the regex filter contains symlinks, it won't work correctly. This command uses devices that already passed through pvscan. Since pvscan applies the regex filter correctly, this command inherits the filtering from pvscan and can skip the regex filter itself. See the previous commit "pvscan: use alternate device names from DEVLINKS to check filter"
2023-01-28 00:56:06 +03:00
if (cmd->filter_regex_skip)
return 1;
devices file: recommend removing filter When the devices file is enabled and the filter is set, recommand that the user remove the filter from lvm.conf since it's ignored.
2021-05-05 21:59:42 +03:00
if (cmd->enable_devices_file && !cmd->filter_regex_with_devices_file) {
/* can't warn in create_filter because enable_devices_file is set later */
if (rf->config_filter && !rf->warned_filter) {
log_warn("Please remove the lvm.conf filter, it is ignored with the devices file.");
rf->warned_filter = 1;
}
if (rf->config_global_filter && !rf->warned_global_filter) {
log_warn("Please remove the lvm.conf global_filter, it is ignored with the devices file.");
rf->warned_global_filter = 1;
}
device usage based on devices file The LVM devices file lists devices that lvm can use. The default file is /etc/lvm/devices/system.devices, and the lvmdevices(8) command is used to add or remove device entries. If the file does not exist, or if lvm.conf includes use_devicesfile=0, then lvm will not use a devices file. When the devices file is in use, the regex filter is not used, and the filter settings in lvm.conf or on the command line are ignored. LVM records devices in the devices file using hardware-specific IDs, such as the WWID, and attempts to use subsystem-specific IDs for virtual device types. These device IDs are also written in the VG metadata. When no hardware or virtual ID is available, lvm falls back using the unstable device name as the device ID. When devnames are used, lvm performs extra scanning to find devices if their devname changes, e.g. after reboot. When proper device IDs are used, an lvm command will not look at devices outside the devices file, but when devnames are used as a fallback, lvm will scan devices outside the devices file to locate PVs on renamed devices. A config setting search_for_devnames can be used to control the scanning for renamed devname entries. Related to the devices file, the new command option --devices <devnames> allows a list of devices to be specified for the command to use, overriding the devices file. The listed devices act as a sort of devices file in terms of limiting which devices lvm will see and use. Devices that are not listed will appear to be missing to the lvm command. Multiple devices files can be kept in /etc/lvm/devices, which allows lvm to be used with different sets of devices, e.g. system devices do not need to be exposed to a specific application, and the application can use lvm on its own set of devices that are not exposed to the system. The option --devicesfile <filename> is used to select the devices file to use with the command. Without the option set, the default system devices file is used. Setting --devicesfile "" causes lvm to not use a devices file. An existing, empty devices file means lvm will see no devices. The new command vgimportdevices adds PVs from a VG to the devices file and updates the VG metadata to include the device IDs. vgimportdevices -a will import all VGs into the system devices file. LVM commands run by dmeventd not use a devices file by default, and will look at all devices on the system. A devices file can be created for dmeventd (/etc/lvm/devices/dmeventd.devices) If this file exists, lvm commands run by dmeventd will use it. Internal implementaion: - device_ids_read - read the devices file . add struct dev_use (du) to cmd->use_devices for each devices file entry - dev_cache_scan - get /dev entries . add struct device (dev) to dev_cache for each device on the system - device_ids_match - match devices file entries to /dev entries . match each du on cmd->use_devices to a dev in dev_cache, using device ID . on match, set du->dev, dev->id, dev->flags MATCHED_USE_ID - label_scan - read lvm headers and metadata from devices . filters are applied, those that do not need data from the device . filter-deviceid skips devs without MATCHED_USE_ID, i.e. skips /dev entries that are not listed in the devices file . read lvm label from dev . filters are applied, those that use data from the device . read lvm metadata from dev . add info/vginfo structs for PVs/VGs (info is "lvmcache") - device_ids_find_renamed_devs - handle devices with unstable devname ID where devname changed . this step only needed when devs do not have proper device IDs, and their dev names change, e.g. after reboot sdb becomes sdc. . detect incorrect match because PVID in the devices file entry does not match the PVID found when the device was read above . undo incorrect match between du and dev above . search system devices for new location of PVID . update devices file with new devnames for PVIDs on renamed devices . label_scan the renamed devs - continue with command processing
2020-06-23 21:25:41 +03:00
return 1;
devices file: recommend removing filter When the devices file is enabled and the filter is set, recommand that the user remove the filter from lvm.conf since it's ignored.
2021-05-05 21:59:42 +03:00
}
device usage based on devices file The LVM devices file lists devices that lvm can use. The default file is /etc/lvm/devices/system.devices, and the lvmdevices(8) command is used to add or remove device entries. If the file does not exist, or if lvm.conf includes use_devicesfile=0, then lvm will not use a devices file. When the devices file is in use, the regex filter is not used, and the filter settings in lvm.conf or on the command line are ignored. LVM records devices in the devices file using hardware-specific IDs, such as the WWID, and attempts to use subsystem-specific IDs for virtual device types. These device IDs are also written in the VG metadata. When no hardware or virtual ID is available, lvm falls back using the unstable device name as the device ID. When devnames are used, lvm performs extra scanning to find devices if their devname changes, e.g. after reboot. When proper device IDs are used, an lvm command will not look at devices outside the devices file, but when devnames are used as a fallback, lvm will scan devices outside the devices file to locate PVs on renamed devices. A config setting search_for_devnames can be used to control the scanning for renamed devname entries. Related to the devices file, the new command option --devices <devnames> allows a list of devices to be specified for the command to use, overriding the devices file. The listed devices act as a sort of devices file in terms of limiting which devices lvm will see and use. Devices that are not listed will appear to be missing to the lvm command. Multiple devices files can be kept in /etc/lvm/devices, which allows lvm to be used with different sets of devices, e.g. system devices do not need to be exposed to a specific application, and the application can use lvm on its own set of devices that are not exposed to the system. The option --devicesfile <filename> is used to select the devices file to use with the command. Without the option set, the default system devices file is used. Setting --devicesfile "" causes lvm to not use a devices file. An existing, empty devices file means lvm will see no devices. The new command vgimportdevices adds PVs from a VG to the devices file and updates the VG metadata to include the device IDs. vgimportdevices -a will import all VGs into the system devices file. LVM commands run by dmeventd not use a devices file by default, and will look at all devices on the system. A devices file can be created for dmeventd (/etc/lvm/devices/dmeventd.devices) If this file exists, lvm commands run by dmeventd will use it. Internal implementaion: - device_ids_read - read the devices file . add struct dev_use (du) to cmd->use_devices for each devices file entry - dev_cache_scan - get /dev entries . add struct device (dev) to dev_cache for each device on the system - device_ids_match - match devices file entries to /dev entries . match each du on cmd->use_devices to a dev in dev_cache, using device ID . on match, set du->dev, dev->id, dev->flags MATCHED_USE_ID - label_scan - read lvm headers and metadata from devices . filters are applied, those that do not need data from the device . filter-deviceid skips devs without MATCHED_USE_ID, i.e. skips /dev entries that are not listed in the devices file . read lvm label from dev . filters are applied, those that use data from the device . read lvm metadata from dev . add info/vginfo structs for PVs/VGs (info is "lvmcache") - device_ids_find_renamed_devs - handle devices with unstable devname ID where devname changed . this step only needed when devs do not have proper device IDs, and their dev names change, e.g. after reboot sdb becomes sdc. . detect incorrect match because PVID in the devices file entry does not match the PVID found when the device was read above . undo incorrect match between du and dev above . search system devices for new location of PVID . update devices file with new devnames for PVIDs on renamed devices . label_scan the renamed devs - continue with command processing
2020-06-23 21:25:41 +03:00
Right, a simple build (without options) is working again.
2008-11-04 01:14:30 +03:00
dm_list_iterate_items(sl, &dev->aliases) {
Move regex functions into libdevmapper.
2007-04-27 22:52:05 +04:00
m = dm_regex_match(rf->engine, sl->str);
o rfilter now checks all aliases for a match
2001-10-25 18:19:39 +04:00
if (m >= 0) {
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
if (dm_bit(rf->accept, m)) {
pvscan: use alternate device names from DEVLINKS to check filter pvscan --cache <dev> is called by our udev rule at a time when all the symlinks for <dev> may not be created yet (by other udev rules.) The regex filter in lvm.conf may refer to <dev> using a symlink name that hasn't yet been created, which would cause <dev> to not match the filter regex. The DEVLINKS env var, set by udev, contains all the symlink names for <dev> that have been or will be created. So, we add all these symlink names to dev->aliases, as if we had found them in /dev. This allows <dev> to be recognized by a regex filter containing a symlink for <dev>.
2023-01-20 02:37:31 +03:00
if (!first && !cmd->filter_regex_set_preferred_name_disable)
Revert "dev-cache: move global variables into cmd struct" This reverts commit 77be3250d926263db0d4daa83a4102078601bac2.
2024-07-08 23:32:41 +03:00
dev_set_preferred_name(sl, dev);
o It's a bit of a hack, but the regex filter now makes sure a device path that passed the filter is at the front of the aliases list.
2001-10-25 18:41:28 +04:00
o rfilter now checks all aliases for a match
2001-10-25 18:19:39 +04:00
return 1;
o It's a bit of a hack, but the regex filter now makes sure a device path that passed the filter is at the front of the aliases list.
2001-10-25 18:41:28 +04:00
}
o if any pattern rejects a device, and there were no accepts then reject !
2001-11-12 20:06:33 +03:00
rejected = 1;
}
o It's a bit of a hack, but the regex filter now makes sure a device path that passed the filter is at the front of the aliases list.
2001-10-25 18:41:28 +04:00
first = 0;
o rfilter now checks all aliases for a match
2001-10-25 18:19:39 +04:00
}
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
devices: support printing the filter that rejects a device Use of this new message function needs to be added to various commands to improve the output.
2020-07-20 20:48:36 +03:00
if (rejected) {
dev->filtered_flags |= DEV_FILTERED_REGEX;
logging: classify log_debug messages Place most log_debug() messages into a class.
2013-01-08 02:30:29 +04:00
log_debug_devs("%s: Skipping (regex)", dev_name(dev));
devices: support printing the filter that rejects a device Use of this new message function needs to be added to various commands to improve the output.
2020-07-20 20:48:36 +03:00
}
Improve filter debug msgs.
2004-11-24 23:36:52 +03:00
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
/*
o rfilter now checks all aliases for a match
2001-10-25 18:19:39 +04:00
* pass everything that doesn't match
* anything.
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
*/
o if any pattern rejects a device, and there were no accepts then reject !
2001-11-12 20:06:33 +03:00
return !rejected;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
}
Check for libsepol. Add some cflow & scope support. Separate out DEFS from CFLAGS. Remove inlines and use unique function names.
2006-04-19 19:33:07 +04:00
static void _regex_destroy(struct dev_filter *f)
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
{
struct rfilter *rf = (struct rfilter *) f->private;
Track recursive filter iteration to avoid refreshing while in use. (2.02.56)
2010-09-22 05:36:13 +04:00
if (f->use_count)
log_error(INTERNAL_ERROR "Destroying regex filter while in use %u times.", f->use_count);
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
dm_pool_destroy(rf->mem);
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
}
devices file: recommend removing filter When the devices file is enabled and the filter is set, recommand that the user remove the filter from lvm.conf since it's ignored.
2021-05-05 21:59:42 +03:00
struct dev_filter *regex_filter_create(const struct dm_config_value *patterns, int config_filter, int config_global_filter)
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
{
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
struct dm_pool *mem = dm_pool_create("filter regex", 10 * 1024);
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
struct rfilter *rf;
struct dev_filter *f;
Use stack return macros throughout.
2008-01-30 16:19:47 +03:00
if (!mem)
return_NULL;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
filter: zero internal structure Valgrind noticed access to unitialized warned_filter.
2024-03-29 23:27:06 +03:00
if (!(rf = dm_pool_zalloc(mem, sizeof(*rf))))
Add devices/preferred_names config regex list for displayed device names. Free a temporary dir string in fcntl_lock_file() after use. Fix a dm_pool_destroy() in matcher_create(). Introduce goto_bad macro.
2007-04-26 20:44:59 +04:00
goto_bad;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
rf->mem = mem;
devices file: recommend removing filter When the devices file is enabled and the filter is set, recommand that the user remove the filter from lvm.conf since it's ignored.
2021-05-05 21:59:42 +03:00
rf->config_filter = config_filter;
rf->config_global_filter = config_global_filter;
Add devices/preferred_names config regex list for displayed device names. Free a temporary dir string in fcntl_lock_file() after use. Fix a dm_pool_destroy() in matcher_create(). Introduce goto_bad macro.
2007-04-26 20:44:59 +04:00
if (!_build_matcher(rf, patterns))
goto_bad;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
Add devices/preferred_names config regex list for displayed device names. Free a temporary dir string in fcntl_lock_file() after use. Fix a dm_pool_destroy() in matcher_create(). Introduce goto_bad macro.
2007-04-26 20:44:59 +04:00
if (!(f = dm_pool_zalloc(mem, sizeof(*f))))
goto_bad;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
f->passes_filter = _accept_p;
Check for libsepol. Add some cflow & scope support. Separate out DEFS from CFLAGS. Remove inlines and use unique function names.
2006-04-19 19:33:07 +04:00
f->destroy = _regex_destroy;
Track recursive filter iteration to avoid refreshing while in use. (2.02.56)
2010-09-22 05:36:13 +04:00
f->use_count = 0;
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
f->private = rf;
add device hints to reduce scanning Save the list of PVs in /run/lvm/hints. These hints are used to reduce scanning in a number of commands to only the PVs on the system, or only the PVs in a requested VG (rather than all devices on the system.)
2018-12-07 23:35:22 +03:00
f->name = "regex";
filters: check for mpath before opening devs Split out the partitioned device filter that needs to open the device and move the multipath filter in front of it. When a device is multipathed, sending I/O to the underlying paths may cause problems, the most obvious being I/O errors visible to lvm if a path is down. Revert the incorrect <backtrace> messages added when a device doesn't pass a filter. Log each filter initialisation to show sequence. Avoid duplicate 'Using $device' debug messages.
2013-08-14 02:26:58 +04:00
log_debug_devs("Regex filter initialised.");
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
return f;
Merge with text format branch. Lots of changes/very little testing so far => there'll be bugs! Use 'vgcreate -M text' to create a volume group with its metadata stored in text files. Text format metadata changes should be reasonably atomic, with a (basic) automatic recovery mechanism if the system crashes while a change is in progress. Add a metadata section to lvm.conf to specify multiple directories if you want (recommended) to keep multiple copies of the metadata (eg on different filesystems). e.g. metadata { dirs = ["/etc/lvm/metadata1","/usr/local/lvm/metadata2"] } Plenty of refinements still in the pipeline.
2002-04-24 22:20:51 +04:00
bad:
Use hash, bitset, malloc, pool from libdevmapper.
2005-10-17 03:03:59 +04:00
dm_pool_destroy(mem);
o Filter for the dev cache that takes values from config file: devices { # first match is final, eg. /dev/ide/cdrom # get's rejected due to the first pattern filter=["r/cdrom/", # don't touch the music ! "a/hd[a-d][0-9]+/", "a/ide/", "a/sd/", "a/md/", "a|loop/[0-9]+|", # accept devfs style loop back "r/loop/", # and reject old style "a/dasd/", "a/dac960/", "a/nbd/", "a/ida/", "a/cciss/", "a/ubd/", "r/.*/"] # reject all others } Alasdair this is ready to roll into the tools now.
2001-10-19 22:20:37 +04:00
return NULL;
}
Copy Permalink