shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cache pool: Add 'update_cache_pool_params'

Browse Source 
Similar function to 'update_thin_pool_params', but for cache.  Performs
the adjustements for chunk_size, metdata device size, etc.
This commit is contained in:
Jonathan Brassow 2014-02-04 11:50:27 -06:00
parent 8ddc7f641c
commit 013cf27bff
4 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/config/defaults.h
View File

@ -81,6 +81,8 @@
#define DEFAULT_CACHE_POOL_METADATA_REQUIRE_SEPARATE_PVS 0
#define DEFAULT_CACHE_POOL_CHUNK_SIZE 64 /* KB */
#define DEFAULT_CACHE_POOL_MIN_METADATA_SIZE 2048 /* KB */
#define DEFAULT_CACHE_POOL_MAX_METADATA_SIZE (16 * 1024 * 1024) /* KB */
#define DEFAULT_UMASK 0077

52
lib/metadata/cache_manip.c
View File

@ -28,6 +28,58 @@
#include "defaults.h"
#include "lvm-exec.h"
int update_cache_pool_params(struct volume_group *vg, unsigned attr,
int passed_args,
uint32_t data_extents, uint32_t extent_size,
int *chunk_size_calc_method, uint32_t *chunk_size,
thin_discards_t *discards,
uint64_t *pool_metadata_size, int *zero)
{
uint64_t min_meta_size;
if ((*chunk_size < DM_CACHE_MIN_DATA_BLOCK_SIZE) ||
(*chunk_size > DM_CACHE_MAX_DATA_BLOCK_SIZE)) {
log_error("Chunk size must be in the range %s to %s.",
display_size(vg->cmd, DM_CACHE_MIN_DATA_BLOCK_SIZE),
display_size(vg->cmd, DM_CACHE_MAX_DATA_BLOCK_SIZE));
return 0;
}
if (*chunk_size & (DM_CACHE_MIN_DATA_BLOCK_SIZE - 1)) {
log_error("Chunk size must be a multiple of %u sectors.",
DM_CACHE_MIN_DATA_BLOCK_SIZE);
return 0;
}
/*
* Default meta size is:
* (4MiB + (16 Bytes for each chunk-sized block))
* ... plus a good amount of padding (2x) to cover any
* policy hint data that may be added in the future.
*/
min_meta_size = 16 * (data_extents * vg->extent_size);
min_meta_size /= *chunk_size; /* # of Bytes we need */
min_meta_size *= 2; /* plus some padding */
min_meta_size /= 512; /* in sectors */
min_meta_size += 4*1024*2; /* plus 4MiB */
if (!*pool_metadata_size)
*pool_metadata_size = min_meta_size;
if (*pool_metadata_size < min_meta_size) {
*pool_metadata_size = min_meta_size;
log_print("Increasing metadata device size to %"
PRIu64 " sectors", *pool_metadata_size);
}
if (*pool_metadata_size > (2 * DEFAULT_CACHE_POOL_MAX_METADATA_SIZE)) {
*pool_metadata_size = 2 * DEFAULT_CACHE_POOL_MAX_METADATA_SIZE;
log_print("Reducing metadata device size to %" PRIu64 " sectors",
*pool_metadata_size);
}
return 1;
}
/*
* lv_cache_create
* @pool

6
lib/metadata/metadata-exported.h
View File

@ -1020,6 +1020,12 @@ int lv_raid_remove_missing(struct logical_volume *lv);
/* -- metadata/raid_manip.c */
/* ++ metadata/cache_manip.c */
int update_cache_pool_params(struct volume_group *vg, unsigned attr,
int passed_args,
uint32_t data_extents, uint32_t extent_size,
int *chunk_size_calc_method, uint32_t *chunk_size,
thin_discards_t *discards,
uint64_t *pool_metadata_size, int *zero);
struct logical_volume *lv_cache_create(struct logical_volume *pool,
struct logical_volume *origin);
int lv_cache_remove(struct logical_volume *cache_lv);

9
tools/lvcreate.c
View File

@ -230,6 +230,15 @@ static int _determine_snapshot_type(struct volume_group *vg,
static int _lvcreate_update_pool_params(struct volume_group *vg,
struct lvcreate_params *lp)
{
if (seg_is_cache_pool(lp))
return update_cache_pool_params(vg, lp->target_attr,
lp->passed_args,
lp->extents, vg->extent_size,
&lp->thin_chunk_size_calc_policy,
&lp->chunk_size, &lp->discards,
&lp->poolmetadatasize,
&lp->zero);
return update_thin_pool_params(vg, lp->target_attr, lp->passed_args,
lp->extents, vg->extent_size,
&lp->thin_chunk_size_calc_policy,