shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-08-30 05:49:28 +03:00
Code Releases Activity

dmeventd: use dm_hold_control_dev

Browse Source 
Need here to keep  control device opened while there is 'any' dso
plugin loaded - otherwise there would a race closing controlfd
inside lvm2 plugin while some other monitoring thread would
tried to execute another WAITEVENT task.
This commit is contained in:
Zdenek Kabelac
2015-10-21 20:52:29 +02:00
parent efc76ca33d
commit 02eb000f51
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW_DM
View File

@ -1,5 +1,6 @@
Version 1.02.110 - Version 1.02.110 -
====================================== ======================================
Dmeventd closes control device when no device is monitored.
Thin plugin for dmeventd improved percentage usage. Thin plugin for dmeventd improved percentage usage.
Snapshot plugin for dmeventd improved percentage usage. Snapshot plugin for dmeventd improved percentage usage.
Add dm_hold_control_dev to allow holding of control device open. Add dm_hold_control_dev to allow holding of control device open.

13
daemons/dmeventd/dmeventd.c
View File

@ -282,6 +282,13 @@ static void _lib_put(struct dso_data *data)
dlclose(data->dso_handle); dlclose(data->dso_handle);
UNLINK_DSO(data); UNLINK_DSO(data);
_free_dso_data(data); _free_dso_data(data);
/* Close control device if there is no plugin in-use */
if (dm_list_empty(&_dso_registry)) {
DEBUGLOG("Unholding control device.");
dm_hold_control_dev(0);
dm_lib_release();
}
} }
} }
@ -344,6 +351,12 @@ static struct dso_data *_load_dso(struct message_data *data)
goto_bad; goto_bad;
} }
/* Keep control device open until last user closes */
if (dm_list_empty(&_dso_registry)) {
DEBUGLOG("Holding control device open.");
dm_hold_control_dev(1);
}
/* /*
* Keep handle to close the library once * Keep handle to close the library once
* we've got no references to it any more. * we've got no references to it any more.