shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Give correct error message when creating a too-small snapshot (BZ 587063)

Browse Source
This commit is contained in:
Petr Rockai 2010-10-13 13:52:53 +00:00
parent 7c9fd3ea84
commit 042312952c
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/metadata/lv_manip.c
View File

@ -3123,6 +3123,11 @@ int lv_create_single(struct volume_group *vg,
return 0;
}
if (lp->snapshot && (lp->extents * vg->extent_size < 2 * lp->chunk_size)) {
log_error("Unable to create a snapshot smaller than 2 chunks.");
return 0;
}
if (!seg_is_virtual(lp) &&
vg->free_count < lp->extents) {
log_error("Insufficient free extents (%u) in volume group %s: "

30
test/t-lvcreate-small-snap.sh Normal file
View File

@ -0,0 +1,30 @@
#!/bin/bash
# Copyright (C) 2010 Red Hat, Inc. All rights reserved.
#
# This copyrighted material is made available to anyone wishing to use,
# modify, copy, or redistribute it subject to the terms and conditions
# of the GNU General Public License v.2.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software Foundation,
# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
. ./test-utils.sh
aux prepare_pvs 3
vgcreate -c n -s 1k $vg $devs
lvcreate -n one -l 10 $vg
lvcreate -s -l 8 -n snapA $vg/one
lvcreate -s -c 4k -l 8 -n snapX1 $vg/one
lvcreate -s -c 8k -l 16 -n snapX2 $vg/one
# Check that snapshots that are too small are caught with correct error.
not lvcreate -s -c 8k -l 8 -n snapX3 $vg/one 2>&1 | tee lvcreate.out
not grep "suspend origin one" lvcreate.out
grep "Unable to create a snapshot" lvcreate.out
not lvcreate -s -l 4 -n snapB $vg/one 2>&1 | tee lvcreate.out
not grep "suspend origin one" lvcreate.out
grep "Unable to create a snapshot" lvcreate.out