shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Fix "multisegment RAID1, allocator uses one disk for both legs"

Browse Source 
In case of e.g. 3 PVs, creating or extending a RaidLV causes SubLV
collocation thus putting segments of diffent rimage (and potentially
larger rmeta) SubLVs onto the same PV.  For redundant RaidLVs this'll
compromise redundancy.  Fix by detecting such bogus allocation on
lvcreate/lvextend and reject the request.
This commit is contained in:
heinzm 2023-05-10 18:22:11 +02:00
parent bf794b66f4
commit 05c2b10c5d
1 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
lib/metadata/lv_manip.c
View File

@ -4454,6 +4454,38 @@ static int _lv_extend_layered_lv(struct alloc_handle *ah,
return 1;
}
/* Check either RAID images and metas are being allocated redundantly. */
static int _lv_raid_redundant(struct logical_volume *lv,
struct dm_list *allocatable_pvs, int meta)
{
uint32_t nlvs, s;
struct lv_segment *seg = first_seg(lv);
struct pv_list *pvl;
if (meta && !seg->meta_areas)
return 1;
dm_list_iterate_items(pvl, allocatable_pvs) {
nlvs = 0;
for (s = 0; s < seg->area_count; s++) {
struct logical_volume *slv = meta ? seg_metalv(seg, s) : seg_lv(seg, s);
if (slv && lv_is_on_pv(slv, pvl->pv) && nlvs++)
return 0;
}
}
return 1;
}
/* Check both RAID images and metas are being allocated redundantly. */
static int _lv_raid_redundant_allocation(struct logical_volume *lv, struct dm_list *allocatable_pvs)
{
return _lv_raid_redundant(lv, allocatable_pvs, 0) &&
_lv_raid_redundant(lv, allocatable_pvs, 1);
}
/*
* Entry point for single-step LV allocation + extension.
* Extents is the number of logical extents to append to the LV unless
@ -4556,6 +4588,15 @@ int lv_extend(struct logical_volume *lv,
mirrors, stripes, stripe_size)))
goto_out;
if (segtype_is_raid(segtype) &&
alloc != ALLOC_ANYWHERE &&
!(r = _lv_raid_redundant_allocation(lv, allocatable_pvs))) {
log_error("Insufficient suitable allocatable extents for logical volume %s", display_lvname(lv));
if (!lv_remove(lv) || !vg_write(lv->vg) || !vg_commit(lv->vg))
return_0;
goto out;
}
if (lv_raid_has_integrity(lv)) {
if (!lv_extend_integrity_in_raid(lv, allocatable_pvs)) {
r = 0;