shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

validation: support empty lv segments

Browse Source 
Revert 373372c8ab and instead update
our validation code to handle LVs with empty segment - currently
we should need this only for pvmove operation, thus such LV should
have name  'pvmove%u'.

This fixes a problem where user tried i.e. pvmove on a VG with single
PV - as reported: https://github.com/lvmteam/lvm2/issues/148

Reported-by: bob@redhat.com
This commit is contained in:
Zdenek Kabelac 2024-08-22 14:27:10 +02:00
parent 9df8dd97c3
commit 07b6174f7c
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/metadata/lv_manip.c
View File

@ -8654,19 +8654,9 @@ int insert_layer_for_segments_on_pv(struct cmd_context *cmd,
layer_lv->name, lv_where->name, layer_lv->name, lv_where->name,
pvl ? pv_dev_name(pvl->pv) : "any"); pvl ? pv_dev_name(pvl->pv) : "any");
/* Temporarily hide layer_lv from vg->lvs list
* so the lv_split_segment() passes vg_validate()
* since here layer_lv has empty segment list */
if (!(lvl = find_lv_in_vg(lv_where->vg, layer_lv->name)))
return_0;
dm_list_del(&lvl->list);
if (!_align_segment_boundary_to_pe_range(lv_where, pvl)) if (!_align_segment_boundary_to_pe_range(lv_where, pvl))
return_0; return_0;
/* Put back layer_lv in vg->lv */
dm_list_add(&lv_where->vg->lvs, &lvl->list);
/* Work through all segments on the supplied PV */ /* Work through all segments on the supplied PV */
dm_list_iterate_items(seg, &lv_where->segments) { dm_list_iterate_items(seg, &lv_where->segments) {
for (s = 0; s < seg->area_count; s++) { for (s = 0; s < seg->area_count; s++) {

8
lib/metadata/merge.c
View File

@ -744,8 +744,12 @@ int check_lv_segments(struct logical_volume *lv, int complete_vg)
} }
if (!le) { if (!le) {
log_error("LV %s: has no segment.", lv->name); if (sscanf(lv->name, "pvmove%u", &le) == 1)
inc_error_count; log_debug("LV pvmove %s has no segment.", lv->name);
else {
log_error("LV %s: has no segment.", lv->name);
inc_error_count;
}
} }
dm_list_iterate_items(sl, &lv->segs_using_this_lv) { dm_list_iterate_items(sl, &lv->segs_using_this_lv) {